Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[session_view] Implement versioned HTTP API / translation layer #158687

Closed
mitodrummer opened this issue May 30, 2023 · 0 comments
Closed

[session_view] Implement versioned HTTP API / translation layer #158687

mitodrummer opened this issue May 30, 2023 · 0 comments
Assignees
@mitodrummer
Labels
Project:Serverless Work as part of the Serverless project for its initial release v8.9.0

Comments

@mitodrummer
Copy link
Contributor

To allow for a "zero downtime" experience with the new Serverless offering, all internal "Session View" http routes must be versioned. Responses should also have their own types as a means to a path towards backwards compatibility.

see this example PR of work already done by ML team:
#156949

There is a new Core "versioned" router, so we should update to using that.
see: https://docs.google.com/document/d/1gquGhkn_OMqMCKo6a_2h0ArxzUsbVKtcOi2YFiGPFZ4/edit#bookmark=id.kahpa31pzm9i
https://docs.elastic.dev/kibana-dev-docs/versioning-http-apis#4-adhere-to-the-http-versioning-specification

It would also be prudent to update all ES queries to limit to fields only Session View needs to display it's data, currently we are pulling the full document.
@mitodrummer mitodrummer added Team: Cloud Native Integrations Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels May 30, 2023
@mitodrummer mitodrummer self-assigned this May 31, 2023
@mitodrummer mitodrummer mentioned this issue Jun 3, 2023
Merged
1 task
mitodrummer added a commit that referenced this issue Jun 7, 2023
@mitodrummer @kibanamachine
[Session view] [serverless] versioned APIs and other improvements (#1…
ed0d341 
…58982)

## Summary

### Issues: 
- #158687
- #158686

### Fixes
- API routes now versioned
- Moved index selection logic to session_view plugin, added tests
- fields now defined for all ES queries
- types consolidated, and put under a latest/v1 export paradigm

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitodrummer mitodrummer

Labels
Project:Serverless Work as part of the Serverless project for its initial release v8.9.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitodrummer