-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloud_defend] Implement versioned HTTP API / translation layer #158688
Labels
Comments
mitodrummer
added
Project:Serverless
Work as part of the Serverless project for its initial release
v8.9.0
labels
May 30, 2023
mitodrummer
added
Team: Cloud Native Integrations
and removed
needs-team
Issues missing a team label
labels
May 30, 2023
mitodrummer
added a commit
that referenced
this issue
Jun 13, 2023
## Summary ### Issues: - #158688 ### Fixes - API routes now versioned - types put under a latest/v1 export paradigm ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this issue
Jun 13, 2023
## Summary ### Issues: - elastic#158688 ### Fixes - API routes now versioned - types put under a latest/v1 export paradigm ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this issue
Jun 13, 2023
## Summary ### Issues: - elastic#158688 ### Fixes - API routes now versioned - types put under a latest/v1 export paradigm ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this issue
Jun 14, 2023
## Summary ### Issues: - elastic#158688 ### Fixes - API routes now versioned - types put under a latest/v1 export paradigm ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
To allow for a "zero downtime" experience with the new Serverless offering, all internal "cloud_defend" plugin http routes must be versioned. Responses should also have their own types as a means to a path towards backwards compatibility.
see this example PR of work already done by ML team:
#156949
There is a new Core "versioned" router, so we should update to using that.
see: https://docs.google.com/document/d/1gquGhkn_OMqMCKo6a_2h0ArxzUsbVKtcOi2YFiGPFZ4/edit#bookmark=id.kahpa31pzm9i
https://docs.elastic.dev/kibana-dev-docs/versioning-http-apis#4-adhere-to-the-http-versioning-specification.
The text was updated successfully, but these errors were encountered: