Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Create Serverless integration tests for the Threshold rule #161458

Closed
Tracked by #161237
fkanout opened this issue Jul 7, 2023 · 1 comment · Fixed by #161569
Closed
Tracked by #161237

[AO] Create Serverless integration tests for the Threshold rule #161458

fkanout opened this issue Jul 7, 2023 · 1 comment · Fixed by #161569
Assignees
@fkanout
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Milestone
8.10

Comments

@fkanout
Copy link
Contributor

fkanout commented Jul 7, 2023 •
edited
Loading

📝 Summary

As the threshold rule is part of/done for serverless, and serverless tests differ from stateful ones, we need to write integration tests for the threshold rule.

✅ AC
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Jul 7, 2023
@fkanout fkanout self-assigned this Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout mentioned this issue Jul 10, 2023
Merged
fkanout added a commit that referenced this issue Jul 24, 2023
@fkanout
[AO][SERVERLESS] Create serverless integration tests for the Threshol…
6bae659 
…d rule #161458 (#161569)

## Summary

It fixes #161458 by adding API integration tests for the Threshold rule,
with many scenarios (file per scenario), and each scenario has a
complete life-cycle

### The scenario life-cycle 
- Generating data using the `fake_host` dataset from the high-card
- Create a DataView based on the generated data
- Create the rule and wait to be active
- Get the fired alert and matches its value 
- Clean up

### The covered scenarios 
- Avg. percentage, fires alert
- Avg. percentage, fires alert with no data
- Custom equation on bytes filed, fires alert
- Doc count, fires alert
- Group by two fields, fires alert.

---------
@maryam-saeidi maryam-saeidi mentioned this issue Jul 31, 2023
Closed
4 tasks
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@fkanout
[AO][SERVERLESS] Create serverless integration tests for the Threshol…
f3d12e9 
…d rule elastic#161458 (elastic#161569)

## Summary

It fixes elastic#161458 by adding API integration tests for the Threshold rule,
with many scenarios (file per scenario), and each scenario has a
complete life-cycle

### The scenario life-cycle 
- Generating data using the `fake_host` dataset from the high-card
- Create a DataView based on the generated data
- Create the rule and wait to be active
- Get the fired alert and matches its value 
- Clean up

### The covered scenarios 
- Avg. percentage, fires alert
- Avg. percentage, fires alert with no data
- Custom equation on bytes filed, fires alert
- Doc count, fires alert
- Group by two fields, fires alert.

---------
@emma-raffenne emma-raffenne added this to the 8.10 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkanout fkanout

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Projects
None yet
Milestone
8.10
Development

Successfully merging a pull request may close this issue.

[AO][SERVERLESS] Create serverless integration tests for the Threshold rule #161458 fkanout/kibana
3 participants
@fkanout @elasticmachine @emma-raffenne