Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDataTable] Redesign Document column #164634

Open
3 of 5 tasks
Tracked by #168084
kertal opened this issue Aug 23, 2023 · 1 comment
Open
3 of 5 tasks
Tracked by #168084

[UnifiedDataTable] Redesign Document column #164634

kertal opened this issue Aug 23, 2023 · 1 comment
Assignees
@jughosta
Labels
blocked Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@kertal
Copy link
Member

kertal commented Aug 23, 2023 •
edited
Loading

This issue aims to redesign the current way the Document column is rendered in Discover.

Current State:

Image

Figma Redesign:

Image

POC PR version:

Image

Tasks:

  • Get rid of the background of the field names
  • Adjust paddings & margins so it fits the Figma (if possible)
  • Set the field names to semi-bold
  • Add a field token to the field names
    • This is currently blocked due to the performance impact so we would need research an alternative to inline rendering of tokens
  • Allow users to opt out of viewing the tokens via grid settings

Out of scope:

  • Change the font face

Thinks to keep in mind

  • Discover's data table becomes the UnifiedDataTable, so we have more than one consumer soon that will be impacted by this change
  • For the tokens it could be a separate PR, for sure, if it makes sense
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Aug 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Aug 23, 2023
@kertal kertal added the loe:small Small Level of Effort label Aug 23, 2023
@kertal kertal mentioned this issue Aug 24, 2023
Closed
This was referenced Sep 6, 2023
Merged
Closed
jughosta added a commit that referenced this issue Sep 12, 2023
@jughosta @kibanamachine @davismcphee
[Discover] Redesign for the grid, panels and sidebar v1 (#165866)
6cb937a 
## Summary

### Part 1

- Resolves #164287
- Closes #146339
- Previously separate PR #164187

Changes:
- ~~swaps checkbox and row selection~~
- removes vertical borders
- adds rows highlight
- increases cell padding
- adds row stripes
- updates header background
- removes grey background from field name and makes it bolder (part of
#164634)
- updates Surrounding Documents side paddings

### Part 2

- Resolves #164661
- Previously separate PR #165687

Changes:
- removes background from panels, tabs and sidebar
- updates "Add a field" button style
- removes shadow from field list items
- makes field search compact

### Part 3

- Resolves #164662

Changes:
- wraps "Add a field" button in its own container with a top border
- ~~adds a drag handle to sidebar items~~
- ~~adds new Show/Hide buttons to toggle sidebar~~ moves sidebar toggle
button from discover plugin to unified field list
- reduces spaces between sidebar items from 4px to 2px
- reduces padding on Single Document page
- removes border above grid tabs

<img width="600" alt="Screenshot 2023-09-07 at 14 39 48"
src="https://github.com/elastic/kibana/assets/1415710/976db247-fd70-4c9b-8634-552ece45b522">


Please note that "auto" row height is in a separate PR which is also
ready for review #164218

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
@jughosta jughosta mentioned this issue Sep 12, 2023
Closed
4 tasks
@kertal kertal mentioned this issue Oct 5, 2023
Closed
@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 18, 2023
@kertal kertal added the blocked label Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
blocked Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
3 participants
@kertal @jughosta @elasticmachine