Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard navigation] Show icon on external links and Dashboard links that open in a new tab #165771

Closed
nickpeihl opened this issue Sep 5, 2023 · 2 comments · Fixed by #174407
Closed

[Dashboard navigation] Show icon on external links and Dashboard links that open in a new tab #165771

nickpeihl opened this issue Sep 5, 2023 · 2 comments · Fixed by #174407
Assignees
@Heenawter
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nickpeihl
Copy link
Member

External links and dashboard links that open in a new tab should probably include the external icon.

There doesn't seem to be an external prop on EuiListGroupItem, so we may have to append the icon inline.
@nickpeihl nickpeihl added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Sep 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

This was referenced Sep 5, 2023
Closed
Closed
@nickpeihl nickpeihl self-assigned this Sep 19, 2023
@ThomThomson ThomThomson assigned Heenawter and unassigned nickpeihl Nov 7, 2023
@Heenawter Heenawter mentioned this issue Nov 8, 2023
Merged
8 tasks
@Heenawter
Copy link
Contributor

Heenawter commented Nov 20, 2023 •
edited
Loading

Blocked until EUI is updated to include elastic/eui@7740aa3 (version >= 91.1.0)

Edit:
Blocked on #173569

@Heenawter Heenawter removed the blocked label Jan 5, 2024
@Heenawter Heenawter mentioned this issue Jan 5, 2024
Merged
6 tasks
Heenawter added a commit that referenced this issue Jan 8, 2024
@Heenawter
[Dashboard Navigation] Add external link icon (#174407)
928a35d 
Closes #165771

## Summary

This PR adds the `external` prop to links in the Link panel in the
following cases:
1. A dashboard link has the "Open in new tab" setting set to `true`
2. All URLs, regardless of if the "Open in new tab" setting is set to
`true` or `false`

This `external` prop renders the popout icon beside the links, like so:


![linksExternalProp](https://github.com/elastic/kibana/assets/8698078/3bc1ea05-fffd-455a-a4e3-81456bb6b024)



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this issue Jan 9, 2024
@Heenawter @clintandrewhall
[Dashboard Navigation] Add external link icon (elastic#174407)
6dc6a15 
Closes elastic#165771

## Summary

This PR adds the `external` prop to links in the Link panel in the
following cases:
1. A dashboard link has the "Open in new tab" setting set to `true`
2. All URLs, regardless of if the "Open in new tab" setting is set to
`true` or `false`

This `external` prop renders the popout icon beside the links, like so:


![linksExternalProp](https://github.com/elastic/kibana/assets/8698078/3bc1ea05-fffd-455a-a4e3-81456bb6b024)



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
delanni pushed a commit to delanni/kibana that referenced this issue Jan 11, 2024
@Heenawter @delanni
[Dashboard Navigation] Add external link icon (elastic#174407)
3a3473a 
Closes elastic#165771

## Summary

This PR adds the `external` prop to links in the Link panel in the
following cases:
1. A dashboard link has the "Open in new tab" setting set to `true`
2. All URLs, regardless of if the "Open in new tab" setting is set to
`true` or `false`

This `external` prop renders the popout icon beside the links, like so:


![linksExternalProp](https://github.com/elastic/kibana/assets/8698078/3bc1ea05-fffd-455a-a4e3-81456bb6b024)



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@Heenawter @CoenWarmer
[Dashboard Navigation] Add external link icon (elastic#174407)
5680b02 
Closes elastic#165771

## Summary

This PR adds the `external` prop to links in the Link panel in the
following cases:
1. A dashboard link has the "Open in new tab" setting set to `true`
2. All URLs, regardless of if the "Open in new tab" setting is set to
`true` or `false`

This `external` prop renders the popout icon beside the links, like so:


![linksExternalProp](https://github.com/elastic/kibana/assets/8698078/3bc1ea05-fffd-455a-a4e3-81456bb6b024)



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard Navigation] Add external link icon Heenawter/kibana
3 participants
@nickpeihl @Heenawter @elasticmachine