Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDocViewer] Add the flyout to the package/plugin #167846

Open
Tracked by #163284
kertal opened this issue Oct 3, 2023 · 1 comment
Open
Tracked by #163284

[UnifiedDocViewer] Add the flyout to the package/plugin #167846

kertal opened this issue Oct 3, 2023 · 1 comment
Labels
Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@kertal
Copy link
Member

kertal commented Oct 3, 2023

Currently, the unified doc viewer component does not include a flyout. This enables the unified doc viewer to be embedded without the flyout for the single document view. In many other usages, the component is wrapped in a flyout. This issue aims to add flyout support to the document viewer package/plugin.

To enable this, we will add a new parameter, isFlyoutView. When true (the default), the unified doc viewer component will be wrapped in a flyout:

Image

The flyout is currently implemented in Discover (source). This flyout will be moved into the kbn-unified-doc-viewer package.

The flyout header includes actions that can be taken on a document level. These will become part of the unified doc viewer API.
@kertal kertal added the Feature:UnifiedDocViewer Issues relating to the unified doc viewer component label Oct 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 3, 2023
@kertal kertal added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed needs-team Issues missing a team label labels Oct 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 4, 2024
@kertal kertal mentioned this issue Jan 15, 2024
Closed
@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 14, 2024
@kertal kertal mentioned this issue May 31, 2024
Merged
9 tasks
@lukasolson lukasolson removed their assignment Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @lukasolson @elasticmachine @davismcphee