Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDocViewer] Component & Redesign #163284

Closed
8 of 9 tasks
kertal opened this issue Aug 7, 2023 · 2 comments
Closed
8 of 9 tasks

[UnifiedDocViewer] Component & Redesign #163284

kertal opened this issue Aug 7, 2023 · 2 comments
Labels
enhancement New value added to drive a business result epic Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:large Large Level of Effort loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@kertal
Copy link
Member

kertal commented Aug 7, 2023 •
edited
Loading

This issue aims to make the layout of the DocViewer more compact. The following measures should be applied

  • Header: Change the title in the flyout from Expanded document to Document. Move the document pagination from the actions row to the right side of the title.
  • Header: Rename “View” to “Actions”. Change labels from “Single document” and “Surrounding documents” to “View single document” and “View surrounding documents”. This change is in response to the ask to make this section scalable without taking up more vertical space. See the screenshots below for the icon-only version which we should apply in the event of having more than two actions.
  • For desktop, remove the Actions column. Instead, use the floating actions we introduced for Controls. These floating actions should appear on the left side of the row. For small screens where hover is unavailable, we can fallback to the current implementation. See:
Frame 501 Frame 500

Icon-only actions in header

image

Originally posted by @andreadelrio in #160306 (comment)

Tasks
Beta Give feedback
  1. [UnifiedDocViewer] Redesign Actions to be responsive #163239
    Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:medium loe:medium
    jughosta
  2. [UnifiedDocViewer] Apply push flyout style #163798
    Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:high loe:small
    lukasolson
  3. [UnifiedDocViewer] Redesign Header Title #164660
    Feature:Discover Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:high loe:small
    jughosta
  4. [UnifiedDocViewer] Use the floating actions and get rid of that empty space on the left #164617
    Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:medium loe:small
    lukasolson
  5. [UnifiedDocViewer] Extension Point: Actions #168107
    Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:low loe:medium
    lukasolson
  6. [UnifiedDocViewer] Filter on field name and value in expanded document view #163275
    Feature:UnifiedDocViewer Project:OneDiscover Team:DataDiscovery enhancement impact:medium loe:medium usability
    jughosta
  7. [UnifiedDocViewer] Support wildcard fieldname search #168607
    Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:medium loe:small
    jughosta
  8. [UnifiedDocViewer] Add the flyout to the package/plugin #167846
    Feature:UnifiedDocViewer Team:DataDiscovery impact:low loe:medium refactoring
  9. [UnifiedDocViewer] Migrate table to EuiDataGrid #174745
    Feature:Discover Feature:UnifiedDocViewer Team:DataDiscovery enhancement impact:medium loe:needs-research
    jughosta
@kertal kertal added the Feature:UnifiedDocViewer Issues relating to the unified doc viewer component label Aug 7, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 7, 2023
@kertal kertal added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed needs-team Issues missing a team label labels Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the enhancement New value added to drive a business result label Aug 7, 2023
@kertal kertal mentioned this issue Aug 7, 2023
Closed
@davismcphee davismcphee added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated labels Sep 8, 2023
@kertal kertal added the Meta label Sep 26, 2023
@kertal kertal changed the title [UnifiedDocViewer] A more compact layout [UnifiedDocViewer] Redesign Sep 27, 2023
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort labels Sep 28, 2023
@kertal kertal changed the title [UnifiedDocViewer] Redesign [UnifiedDocViewer] Component & Redesign Oct 3, 2023
@davismcphee davismcphee mentioned this issue Nov 10, 2023
Merged
@kertal kertal added epic Meta and removed Meta labels Nov 30, 2023
@kertal
Copy link
Member Author

kertal commented Sep 2, 2024

Closing this for now as the majority of tasks is done, and 2 remaining tasks
#163275 -> filtering on value in UnifiedDocViewer is now part of OneDiscover
#167846 -> Adding the flyout to the package could be closeable, as our priorities shifted to OneDiscover

@kertal kertal closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result epic Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:large Large Level of Effort loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kertal @elasticmachine @davismcphee