Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDocViewer] Apply push flyout style #163798

Closed
Tracked by #163284
kertal opened this issue Aug 14, 2023 · 3 comments · Fixed by #166406
Closed
Tracked by #163284

[UnifiedDocViewer] Apply push flyout style #163798

kertal opened this issue Aug 14, 2023 · 3 comments · Fixed by #166406
Assignees
@lukasolson
Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@kertal
Copy link
Member

kertal commented Aug 14, 2023

Change the flyout style of the UnifiedDocViewer to "Push", with pushMinBreakpoint to xl (1200). Below that breakdown point, the overlay version is displayed

Overlay version (automatically applied)

Image

Breakpoint version (1200px) with field list hidden

Image

Macbook 16``full width 1728px

Image
@kertal kertal added the enhancement New value added to drive a business result label Aug 14, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 14, 2023
@kertal kertal added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed needs-team Issues missing a team label labels Aug 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the Feature:UnifiedDocViewer Issues relating to the unified doc viewer component label Aug 14, 2023
@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Aug 14, 2023
@kertal kertal mentioned this issue Aug 21, 2023
Closed
@davismcphee davismcphee added the loe:small Small Level of Effort label Sep 8, 2023
@lukasolson lukasolson mentioned this issue Sep 13, 2023
Merged
2 tasks
@kertal kertal mentioned this issue Sep 27, 2023
Closed
@kertal kertal added the blocked label Nov 21, 2023
@kertal
Copy link
Member Author

kertal commented Nov 21, 2023

This has a dependency on elastic/eui#287

@kertal
Copy link
Member Author

kertal commented Jan 12, 2024

This is now unblocked due to #174487

@kertal kertal removed the blocked label Jan 12, 2024
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
@lukasolson @kibanamachine
@stratoula @davismcphee @yuliacech
Use push flyout for Discover document flyout (elastic#166406)
046a1b8 
## Summary

Closes elastic#163798. 
Closes elastic#160306

Uses `"push"` style for the document viewer flyout in Discover.

Before:

<img width="1552" alt="image"
src="https://github.com/elastic/kibana/assets/1178348/7e3e7c35-7317-44ae-b614-55eb337f742b">

After:

<img width="1552" alt="image"
src="https://github.com/elastic/kibana/assets/1178348/542b78e6-3c82-47a5-b35f-1c8635e21580">

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
@davismcphee davismcphee mentioned this issue Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use push flyout for Discover document flyout lukasolson/kibana
4 participants
@kertal @lukasolson @elasticmachine @davismcphee