Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Correct order of ES Query and Custom threshold rule types #167876

Closed
maryam-saeidi opened this issue Oct 3, 2023 · 1 comment · Fixed by #168013
Closed

[AO] Correct order of ES Query and Custom threshold rule types #167876

maryam-saeidi opened this issue Oct 3, 2023 · 1 comment · Fixed by #168013
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Oct 3, 2023 •
edited
Loading

📝 Summary

Now that the ES Query rule is available in the observability, we need to show it in the rules flyout in the correct order as mentioned in this comment. (Current order)
Also, the Custom threshold should not be at the top since it is in the technical preview stage.

✅ Acceptance Criteria

  • Fix the order of ES Query and Custom threshold rule types
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0 labels Oct 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi self-assigned this Oct 3, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Correct order of ES Query rule type [AO] Correct order of ES Query and Custom threshold rule type Oct 3, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Correct order of ES Query and Custom threshold rule type [AO] Correct order of ES Query and Custom threshold rule types Oct 3, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Oct 4, 2023
Merged
maryam-saeidi added a commit that referenced this issue Oct 4, 2023
@maryam-saeidi
[AO] Fix alerting rules order (#168013)
634063f 
Closes #167876

## Summary

This PR fixes alerting rules order. Since the Custom threshold rule is
in the tech preview, we want to show it at the end of the list.

|Rules (trial)|Rules (Permium)|
|---|---|

|![image](https://github.com/elastic/kibana/assets/12370520/6e542d8d-a2d8-4dc9-8728-c55bacc87592)|![image](https://github.com/elastic/kibana/assets/12370520/da5c2a82-a5f1-4cb3-aa3c-183fa7af3fa3)|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] Fix alerting rules order maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine