Fix threshold and value format in custom threshold rule similar to what we have for metric threshold in the rule flyout #169364
Assignees
Labels
Team:obs-ux-management
Observability Management User Experience Team
Comments
maryam-saeidi
added
the
Team: Actionable Observability - DEPRECATED
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
paulb-elastic
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
paulb-elastic
removed
the
Team: Actionable Observability - DEPRECATED
maryam-saeidi
added a commit
that referenced
this issue
Nov 14, 2023
Part of #159340 Closes #169364 ## Summary This PR: 1. Removes preFill logic In this PR, I removed the logic about prefilling custom threshold rule params as it was originally for other rule types (not custom equation) and to be used in the Metric threshold rule and the code related to this logic was super confusing, and I wasn't even sure if it works as expected since we haven't used this logic anywhere. I created a [ticket](#170295) to bring back this feature properly later, specifically for the custom equation, and integrate it in one of the apps, such as Infra. We also need to be able to preFill data view information (both adHoc and persisted data view) 2. Renames types and file names - From `metricThreshold` to `customThreshold` - From `metricExplorer` to `expression` 3. Removes unused types 4. Remove logic related to aggregations other than the custom equation at the top level Also, the fields that end with `pct` now have the `%` after the related value: (The reason message was fixed in another PR) <img src="https://github.com/elastic/kibana/assets/12370520/83694d3b-2ee2-4e95-afe9-5a959c76c3c7" width=400 /> ## 🧪 How to test - Nothing has changed related to functionality, so please make sure the custom threshold rule is working as before for - Creating a new rule with multiple conditions - Adding groups - Editing a rule and checking the charts are shown as before - Test both adHoc and persisted data view --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
jillguyonnet
pushed a commit
to jillguyonnet/kibana
that referenced
this issue
Nov 16, 2023
Part of elastic#159340 Closes elastic#169364 ## Summary This PR: 1. Removes preFill logic In this PR, I removed the logic about prefilling custom threshold rule params as it was originally for other rule types (not custom equation) and to be used in the Metric threshold rule and the code related to this logic was super confusing, and I wasn't even sure if it works as expected since we haven't used this logic anywhere. I created a [ticket](elastic#170295) to bring back this feature properly later, specifically for the custom equation, and integrate it in one of the apps, such as Infra. We also need to be able to preFill data view information (both adHoc and persisted data view) 2. Renames types and file names - From `metricThreshold` to `customThreshold` - From `metricExplorer` to `expression` 3. Removes unused types 4. Remove logic related to aggregations other than the custom equation at the top level Also, the fields that end with `pct` now have the `%` after the related value: (The reason message was fixed in another PR) <img src="https://github.com/elastic/kibana/assets/12370520/83694d3b-2ee2-4e95-afe9-5a959c76c3c7" width=400 /> ## 🧪 How to test - Nothing has changed related to functionality, so please make sure the custom threshold rule is working as before for - Creating a new rule with multiple conditions - Adding groups - Editing a rule and checking the charts are shown as before - Test both adHoc and persisted data view --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📝 Summary
We don't have proper formatting for the custom threshold rule. We need to fix that according to what we have in the metric threshold.
✅ Acceptance Criteria
The text was updated successfully, but these errors were encountered: