Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Updated burn rate threshold value is not properly shown in the slo detail page #170605

Closed
mgiota opened this issue Nov 6, 2023 · 7 comments · Fixed by #177076
Closed

[SLO] Updated burn rate threshold value is not properly shown in the slo detail page #170605

mgiota opened this issue Nov 6, 2023 · 7 comments · Fixed by #177076
Assignees
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@mgiota
Copy link
Contributor

mgiota commented Nov 6, 2023

🍒 Summary

When I created an SLO burn rate value, I used the default burn rate thresholds (14.4x for the critical case). When I updated the SLO burn rate value (168x in my example), I would expect the updated value to appear in the burn rate widget in the SLO details page.

edit_burn_rate.mov

✅ Acceptance criteria

  • The updated burn rate threshold should be displayed on the overview burn rate widget in the slo details page
  • The updated burn rate threshold should be reflected on the error rate chart in the slo details page
  • The updated burn rate threshold should be reflected on the rule edit page

Note: I didn't test if lookback window gets displayed correctly. If it is not displayed correctly, update description and acceptance criteria.

@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Feature:SLO labels Nov 6, 2023
@mgiota mgiota self-assigned this Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@mgiota
Copy link
Contributor Author

mgiota commented Nov 6, 2023

@kdelemme @simianhacker Do we maybe have an issue for this already? I remember @simianhacker mentioning in one of our meetings that error rate chart should read the values from the burn rate rule.

Update: @simianhacker I think this is the one, right?

@simianhacker
Copy link
Member

@mgiota Yes... that's the issue

@paulb-elastic paulb-elastic added the Team:obs-ux-management Observability Management User Experience Team label Nov 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@emma-raffenne emma-raffenne removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 9, 2023
@paulb-elastic
Copy link
Contributor

paulb-elastic commented Feb 6, 2024

This was raised by SRE today when I was on the Synthetics call with them.
It's also evident by editing the burn rate rule - the updated value does not appear when re-opening the rule page (note that looking at the saved object, the value IS updated, but the UI on the rule edit page is not reflecting the new value)

Video_2024-02-06_181236

I've added this case to the main description

@paulb-elastic paulb-elastic added the bug Fixes for quality problems that affect the customer experience label Feb 6, 2024
@paulb-elastic
Copy link
Contributor

It seems that #176317 has fixed the edit rule page problem, but not the SLO details page.

Default rule created (which sets a critical burn rate threshold of 14.40)

image

Changed this to 16:

image

Still shows as the original 14.4 on the SLO details page:

image

@paulb-elastic paulb-elastic removed the bug Fixes for quality problems that affect the customer experience label Feb 7, 2024
@paulb-elastic
Copy link
Contributor

I've removed the bug label I added because of #170605 (comment), which has been fixed.

This issue is slightly different, and the original intent was to show the default burn rates, hence why it does not update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants