Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Migrate Change Point Chart #174963

Closed
Tracked by #178375
, #167429
...
ThomThomson opened this issue Jan 16, 2024 · 1 comment · Fixed by #182246
Closed
Tracked by #178375
, #167429
...

[Embeddables Rebuild] Migrate Change Point Chart #174963

ThomThomson opened this issue Jan 16, 2024 · 1 comment · Fixed by #182246
Assignees
@darnautov
Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort :ml project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Jan 16, 2024 •
edited
Loading

As part of the Embeddable refactor, we will need to transition the ML Change Point Embeddable to the new framework.
@ThomThomson ThomThomson mentioned this issue Jan 16, 2024
Open
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 16, 2024
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Jan 16, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 16, 2024
@ThomThomson ThomThomson added the loe:medium Medium Level of Effort label Jan 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this issue Mar 11, 2024
Closed
@darnautov darnautov mentioned this issue May 1, 2024
Merged
6 tasks
darnautov added a commit that referenced this issue May 13, 2024
@darnautov
[ML][Embeddables Rebuild] Migrate Change Point Charts embeddable (#18…
bbd1017 
…2246)

## Summary

Closes #174963

- Decouples UI actions from the embeddable framework 
- Removes custom Edit action and makes use of the default one
- Adds Add action 
- Migrates Change point detection charts to the react embeddable
registry
- Replaces the modal for initializing and editing embeddable config with
the flyout

<img width="1680" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/7648d2ae-927e-40e7-8a87-647ae89bc726">

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort :ml project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML][Embeddables Rebuild] Migrate Change Point Charts embeddable darnautov/kibana
4 participants
@darnautov @peteharverson @ThomThomson @elasticmachine