Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] ES output presets config keyword should be changed #175892

Closed
jlind23 opened this issue Jan 30, 2024 · 4 comments · Fixed by #175901
Closed

[Fleet] ES output presets config keyword should be changed #175892

jlind23 opened this issue Jan 30, 2024 · 4 comments · Fixed by #175901
Assignees
@kpollich
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jlind23
Copy link
Contributor

jlind23 commented Jan 30, 2024 •
edited
Loading

When we introduced the ES output presets, we also make sure that the reserved keys were looked at when added to the custom yaml box and then fallback to the custom option.

While adding them we introduced an issue as we shortened their name instead of using the full ones.

  • Missing queue.mem presets for flush.min_events and flush.timeout
  • idle_timeout should be connection_idle_timeout
  • compression should be compression_level

Here are the settings:

kibana/x-pack/plugins/fleet/common/constants/output.ts

Line 123 in 6fea1ac

export const RESERVED_CONFIG_YML_KEYS = [

This change should be back ported to 8.12

cc @kpollich @jen-huang
@jlind23 jlind23 added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich self-assigned this Jan 30, 2024
@jlind23 jlind23 mentioned this issue Jan 30, 2024
Closed
4 tasks
@kpollich kpollich mentioned this issue Jan 30, 2024
Merged
@jlind23
Copy link
Contributor Author

jlind23 commented Jan 30, 2024

@amolnater-qasource Could you please update your tests cases according to this change?

kpollich added a commit that referenced this issue Jan 30, 2024
@kpollich @kibanamachine
[Fleet] Fix reserved keys for Elasticsearch output YAML box (#175901)
0c93180 
## Summary

Fixes #175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kpollich added a commit to kpollich/kibana that referenced this issue Jan 30, 2024
@kpollich
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
0a639ac 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.

https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0c93180)

# Conflicts:
#	x-pack/plugins/fleet/cypress/e2e/fleet_settings_outputs.cy.ts
@kpollich kpollich mentioned this issue Jan 30, 2024
Merged
kpollich added a commit that referenced this issue Jan 30, 2024
@kpollich
[8.12] [Fleet] Fix reserved keys for Elasticsearch output YAML box (#…
e54f4ce 
…175901) (#175915)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Fix reserved keys for Elasticsearch output YAML box
(#175901)](#175901)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyle
Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2024-01-30T16:30:36Z","message":"[Fleet]
Fix reserved keys for Elasticsearch output YAML box (#175901)\n\n##
Summary\r\n\r\nFixes #175892\r\n\r\nUpdates reserved keywords that
trigger the `Custom` preset for the\r\nElasticsearch
output.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c9318043902474f27d4bbf9739de70994e58cf8","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.13.0"],"number":175901,"url":"https://github.com/elastic/kibana/pull/175901","mergeCommit":{"message":"[Fleet]
Fix reserved keys for Elasticsearch output YAML box (#175901)\n\n##
Summary\r\n\r\nFixes #175892\r\n\r\nUpdates reserved keywords that
trigger the `Custom` preset for the\r\nElasticsearch
output.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c9318043902474f27d4bbf9739de70994e58cf8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175901","number":175901,"mergeCommit":{"message":"[Fleet]
Fix reserved keys for Elasticsearch output YAML box (#175901)\n\n##
Summary\r\n\r\nFixes #175892\r\n\r\nUpdates reserved keywords that
trigger the `Custom` preset for the\r\nElasticsearch
output.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c9318043902474f27d4bbf9739de70994e58cf8"}}]}]
BACKPORT-->
@amolnater-qasource
Copy link

Hi @jlind23

Thank you for the update.

We have updated 02 testcases for this feature under testrail at links:

Further we will revalidate this once latest Snapshot build is available.

Please let us know if anything else is required from our end.
Thanks!

@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 31, 2024
nreese pushed a commit to nreese/kibana that referenced this issue Jan 31, 2024
@kpollich @kibanamachine @nreese
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
c888fff 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@amolnater-qasource
Copy link

Hi @jlind23

We have revalidated these changes on latest 8.12.1 BC1 kibana cloud environment and found it working fine now.

Observations:

  • ES output preset config keywords are now updated as per latest changes.
    • idle_timeout is now connection_idle_timeout
    • compression is now compression_level
    • queue.mem.flush.min_events and queue.mem.flush.timeout are now updated too.

Screen Recording:

Settings.-.Fleet.-.Elastic.-.Google.Chrome.2024-02-02.11-25-31.mp4

Build details:
VERSION: 8.12.1 BC1
BUILD: 70228
COMMIT: 3457f32

Hence we are marking this as QA:Validated.

Please let us know if anything else is required from our end.
Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 2, 2024
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Feb 5, 2024
@kpollich @kibanamachine @WafaaNasr
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
d9a386c 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Feb 6, 2024
@kpollich @kibanamachine @WafaaNasr
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
8716f6b 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@kpollich @kibanamachine @CoenWarmer
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
267a456 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@kpollich @kibanamachine @CoenWarmer
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
ced6d0e 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@kpollich @kibanamachine @fkanout
[Fleet] Fix reserved keys for Elasticsearch output YAML box (elastic#…
ff44d29 
…175901)

## Summary

Fixes elastic#175892

Updates reserved keywords that trigger the `Custom` preset for the
Elasticsearch output.



https://github.com/elastic/kibana/assets/6766512/dda60f6c-d77e-4e98-946b-2c389660074b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpollich kpollich

Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Fix reserved keys for Elasticsearch output YAML box kpollich/kibana
4 participants
@kpollich @elasticmachine @jlind23 @amolnater-qasource