Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Fix autocomplete for _query?format=X #189495

Closed
jughosta opened this issue Jul 30, 2024 · 2 comments · Fixed by #192341
Closed

[DevTools] Fix autocomplete for _query?format=X #189495

jughosta opened this issue Jul 30, 2024 · 2 comments · Fixed by #192341
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jughosta
Copy link
Contributor

Noticed that DevTools suggests text although the correct format would be txt.

Screenshot 2024-07-30 at 13 52 14
@jughosta jughosta added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jul 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@jughosta jughosta added the bug Fixes for quality problems that affect the customer experience label Aug 1, 2024
@alisonelizabeth alisonelizabeth added the Feature:Console Dev Tools Console Feature label Aug 9, 2024
@alisonelizabeth
Copy link
Contributor

This should be a straightforward fix; related code here: https://github.com/elastic/kibana/blob/main/src/plugins/console/server/lib/spec_definitions/json/overrides/esql.query.json#L15

@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Sep 6, 2024
@jughosta jughosta mentioned this issue Sep 9, 2024
Merged
gergoabraham pushed a commit to gergoabraham/kibana that referenced this issue Sep 13, 2024
@jughosta @gergoabraham
[DevTools] Fix format=txt autocomplete for ES|QL (elastic#192341)
0d21c42 
- Closes elastic#189495
- Reference
https://www.elastic.co/guide/en/elasticsearch/reference/current/esql-rest.html#esql-rest-format

<img width="1201" alt="Screenshot 2024-09-09 at 09 51 01"
src="https://github.com/user-attachments/assets/d45d849a-b403-4565-a704-9421b6ba23f1">
markov00 pushed a commit to markov00/kibana that referenced this issue Sep 18, 2024
@jughosta @markov00
[DevTools] Fix format=txt autocomplete for ES|QL (elastic#192341)
e8b0982 
- Closes elastic#189495
- Reference
https://www.elastic.co/guide/en/elasticsearch/reference/current/esql-rest.html#esql-rest-format

<img width="1201" alt="Screenshot 2024-09-09 at 09 51 01"
src="https://github.com/user-attachments/assets/d45d849a-b403-4565-a704-9421b6ba23f1">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DevTools] Fix format=txt autocomplete for ES|QL jughosta/kibana
3 participants
@jughosta @alisonelizabeth @elasticmachine