Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting with comma separated list of mail adresses should create multiple entries #189968

Closed
philippkahr opened this issue Aug 6, 2024 · 1 comment · Fixed by #193128
Closed

Pasting with comma separated list of mail adresses should create multiple entries #189968

philippkahr opened this issue Aug 6, 2024 · 1 comment · Fixed by #193128
Labels
bug Fixes for quality problems that affect the customer experience Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Actions good first issue low hanging fruit Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@philippkahr
Copy link
Contributor

Kibana version: 8.14.3

Describe the bug:

When using the mail connector, you can only add one mail after a time and you need to press enter after every mail for it to be recognised.

Steps to reproduce:

  1. Enter abc@demo.com, def@demo.com
  2. You will get back one mail address that is abc@demo.com, def@demo.com instead of 2 entries, as in abc@demo.com and def@demo.com
Screen.Recording.2024-08-06.at.09.50.48.mov
@philippkahr philippkahr added the bug Fixes for quality problems that affect the customer experience label Aug 6, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 6, 2024
@pmuellr pmuellr changed the title Pasting with coma seperated list of mail adresses should create multiple entries Pasting with comma separated list of mail adresses should create multiple entries Aug 6, 2024
@pmuellr pmuellr added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Aug 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 6, 2024
@cnasikas cnasikas added the good first issue low hanging fruit label Sep 6, 2024
@VriaA VriaA mentioned this issue Sep 17, 2024
Merged
@jcger jcger closed this as completed in 9174588 Oct 2, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 2, 2024
@VriaA
Refactor email input handling to format comma-separated addresses (el…
ae7ed4d 
…astic#193128)

## Summary
This pull request fixes elastic#189968

- Introduced `getFormattedEmailOptions` to split and trim
comma-separated email values
- Updated `EuiComboBox` to handle email entries for `to`, `cc`, and
`bcc` fields

https://github.com/user-attachments/assets/45a70132-8fd7-426e-81cf-62a6bf216408

---------

Signed-off-by: Oyelola Victoria <oyelolaabimbola23@gmail.com>
Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 9174588)
kibanamachine added a commit that referenced this issue Oct 2, 2024
@kibanamachine @VriaA
[8.x] Refactor email input handling to format comma-separated address…
d6edf80 
…es (#193128) (#194669)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Refactor email input handling to format comma-separated addresses
(#193128)](#193128)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Oyelola
Victoria","email":"123843734+VriaA@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-02T09:33:05Z","message":"Refactor
email input handling to format comma-separated addresses (#193128)\n\n##
Summary\r\nThis pull request fixes #189968 \r\n\r\n- Introduced
`getFormattedEmailOptions` to split and trim\r\ncomma-separated email
values\r\n- Updated `EuiComboBox` to handle email entries for `to`,
`cc`, and\r\n`bcc`
fields\r\n\r\n\r\nhttps://github.com/user-attachments/assets/45a70132-8fd7-426e-81cf-62a6bf216408\r\n\r\n---------\r\n\r\nSigned-off-by:
Oyelola Victoria <oyelolaabimbola23@gmail.com>\r\nCo-authored-by: Julian
Gernun <17549662+jcger@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"917458844b51b93d9a62f2e100099a70e1ea4842","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","💝community","v9.0.0","backport:prev-minor"],"title":"Refactor
email input handling to format comma-separated
addresses","number":193128,"url":"https://github.com/elastic/kibana/pull/193128","mergeCommit":{"message":"Refactor
email input handling to format comma-separated addresses (#193128)\n\n##
Summary\r\nThis pull request fixes #189968 \r\n\r\n- Introduced
`getFormattedEmailOptions` to split and trim\r\ncomma-separated email
values\r\n- Updated `EuiComboBox` to handle email entries for `to`,
`cc`, and\r\n`bcc`
fields\r\n\r\n\r\nhttps://github.com/user-attachments/assets/45a70132-8fd7-426e-81cf-62a6bf216408\r\n\r\n---------\r\n\r\nSigned-off-by:
Oyelola Victoria <oyelolaabimbola23@gmail.com>\r\nCo-authored-by: Julian
Gernun <17549662+jcger@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"917458844b51b93d9a62f2e100099a70e1ea4842"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193128","number":193128,"mergeCommit":{"message":"Refactor
email input handling to format comma-separated addresses (#193128)\n\n##
Summary\r\nThis pull request fixes #189968 \r\n\r\n- Introduced
`getFormattedEmailOptions` to split and trim\r\ncomma-separated email
values\r\n- Updated `EuiComboBox` to handle email entries for `to`,
`cc`, and\r\n`bcc`
fields\r\n\r\n\r\nhttps://github.com/user-attachments/assets/45a70132-8fd7-426e-81cf-62a6bf216408\r\n\r\n---------\r\n\r\nSigned-off-by:
Oyelola Victoria <oyelolaabimbola23@gmail.com>\r\nCo-authored-by: Julian
Gernun <17549662+jcger@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"917458844b51b93d9a62f2e100099a70e1ea4842"}}]}]
BACKPORT-->

Co-authored-by: Oyelola Victoria <123843734+VriaA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Actions good first issue low hanging fruit Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor email input handling to format comma-separated addresses VriaA/kibana
4 participants
@pmuellr @cnasikas @philippkahr @elasticmachine