Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] integration test for languages #35463

Closed
Bamieh opened this issue Apr 23, 2019 · 4 comments · Fixed by #70423
Closed

[i18n] integration test for languages #35463

Bamieh opened this issue Apr 23, 2019 · 4 comments · Fixed by #70423
Assignees
@Bamieh
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Apr 23, 2019 •
edited
Loading

We need light integration tests to make sure that kibana launches with our different locales.

Currently if an environment fails in a certain locale, it is only caught by testing each kibana with that locale manually.

Related: #35466
@Bamieh Bamieh self-assigned this Apr 23, 2019
@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@Bamieh
Copy link
Member Author

Bamieh commented Jun 29, 2020

Closed by #70193

The checker now tries to parse messages using intl i18n parser. This will avoid the environments from failing since the check will guarantee we do not have any malformed messages at runtime.

@Bamieh Bamieh added Team:Localization and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-localization (Team:Localization)

This was referenced Jun 29, 2020
Closed
Merged
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bamieh Bamieh

Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[i18n] integrate new translations + new i18n check #70193 Bamieh/kibana
4 participants
@epixa @lukeelmers @Bamieh @elasticmachine