Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] 6.7.2 error in starting up kibana with Chinese locale #35466

Closed
Bamieh opened this issue Apr 23, 2019 · 5 comments
Closed

[i18n] 6.7.2 error in starting up kibana with Chinese locale #35466

Bamieh opened this issue Apr 23, 2019 · 5 comments

Comments

@Bamieh
Copy link
Member

Bamieh commented Apr 23, 2019

@Conky5 caught an error while spinning the environment for the Chinese locale in 6.7.2 this means that the current kibana does not startup in Chinese if Chinese locale is selected.

https://github.com/elastic/infra/issues/9691#issuecomment-485474696

Fix here: #35461

@Bamieh Bamieh added the v6.7.2 label Apr 23, 2019
@Bamieh Bamieh changed the title [i18n] [i18n] 6.7.2 error in starting up kibana with Chinese locale Apr 23, 2019
@alexfrancoeur
Copy link

alexfrancoeur commented Apr 23, 2019

I realize this is listed as 6.7.2 but can we also test and make sure this bug does not affect 7.0 after this has been resolved? @jinmu03 had also run into this issue on 7.0. I wonder if we need to backport there as well?

@jinmu03
Copy link
Contributor

jinmu03 commented Apr 23, 2019

@alexfrancoeur it should be zh-CN instead of zh_CN. Cloud whitelisted only locales with _ as separator

@Bamieh
Copy link
Member Author

Bamieh commented Apr 23, 2019

@alexfrancoeur good point. its only affecting this specific version.

@Bamieh Bamieh closed this as completed Apr 23, 2019
@liza-mae
Copy link
Contributor

I have added automation scripts for this specific case, it would be nice to add some UI checks too, we can look into that later. This is being added for on-prem release testing.

It was not clear to me what needed to be done for cloud, one of the comments said the validator is currently broken on cloud, will follow up and add a test when needed.

If there are other settings or scenario that need be automated, let me know. Thanks.

cc: @joegallo, @epixa, @vogxn

@Bamieh
Copy link
Member Author

Bamieh commented Apr 23, 2019

@liza-mae Thanks for getting on top of this.

I believe we need two simple smoke tests:

  1. kibana startup succeeds in each locale
  2. check kibana loading screen is being displayed in each corresponding locale, (or login page). Checking 1 locale might be enough for this smoke test to pass.

If the second point needs some effort i believe the first point is good as a starting place.

We are still fixing an issue in Cloud for localization to get it working, but we'll need a test or two for that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants