Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting requires clicking sort icon, not column header #3688

Closed
lukasolson opened this issue Apr 27, 2015 · 5 comments · Fixed by #3690
Closed

Sorting requires clicking sort icon, not column header #3688

lukasolson opened this issue Apr 27, 2015 · 5 comments · Fixed by #3690

Comments

@lukasolson
Copy link
Member

  1. Create a new search in discover
  2. Add some columns
  3. Attempt to sort on one of the columns other than time

Nothing happens when you click on the column headers. When you click on the time header, it sorts successfully.

@lukasolson lukasolson added bug Fixes for quality problems that affect the customer experience blocker v4.1.0 v4.0.3 labels Apr 27, 2015
@lukasolson
Copy link
Member Author

Hmm... just kidding, you can sort on the columns, but you have to click on the actual tiny little sort icon, whereas with the time field, you just have to click on the column name.

@lukasolson
Copy link
Member Author

We should probably just standardize how this works. Either we should allow you to click on the header in both cases, or disallow it in both cases.

@lukasolson lukasolson changed the title Can't sort by anything other than time in discover Clicking on column header sorts on some columns, not on others Apr 27, 2015
@lukasolson lukasolson removed the v4.0.3 label Apr 27, 2015
@rashidkpc
Copy link
Contributor

I changed this when I added the ability to remove columns from the header for 2 reasons:

  1. There were a ton of buttons up there. It felt odd that clicking the header had meaning over just clicking the sort icon
  2. We were showing the pointer finger for un-sortable columns (eg, _id), so it looked like clicking on the header should do something, but it didn't. I could've added a class to override the cursor on un-sortable things but just changing the sort to use the icon felt cleaner.

@rashidkpc rashidkpc added discuss and removed bug Fixes for quality problems that affect the customer experience labels Apr 27, 2015
@rashidkpc rashidkpc changed the title Clicking on column header sorts on some columns, not on others Sorting requires clicking sort icon, not column header Apr 27, 2015
@lukasolson
Copy link
Member Author

Yeah, makes total sense. Can we just make the same changes for the Time column as well? I think as long as it is consistent, it would be good. :)

@rashidkpc
Copy link
Contributor

++ I missed that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants