Don't sort time field on column header click #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| <th width="1%"></th> | |||
| <th ng-if="indexPattern.timeFieldName"> | |||
| <span ng-click="sort(indexPattern.timeFieldName)" tooltip="Sort by time">Time <i ng-class="headerClass(indexPattern.timeFieldName)"></i></span> | |||
| <span tooltip="Sort by time">Time <i ng-class="headerClass(indexPattern.timeFieldName)" ng-click="sort(indexPattern.timeFieldName)"></i></span> | |||
There was a problem hiding this comment.
Can you move the tooltip to the <i> as well?
rashidkpc
added a commit
that referenced
this pull request
Apr 28, 2015
Don't sort time field on column header click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent enhancement added the ability to remove a column in discover by clicking on an "x" in the column header. As part of this change, clicking on the table column header no longer sorts by that column, and instead you need to click on the actual sort icon to sort by the column. This change made sorting by a column more consistent with other buttons in column headers, like remove column, move column left/right, etc.)
However, the Time column there by default for timestamp index patterns didn't get this same change. This PR simply makes the same change to the Time column.
Closes #3688.