-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add columns from doc table #3526
Add columns from doc table #3526
Conversation
425053b
to
542638f
Compare
<span ng-click="sort(name)" class="table-header-name" tooltip="{{tooltip(name)}}"> | ||
{{name | shortDots}} <i ng-class="headerClass(name)"></i> | ||
<span class="table-header-name"> | ||
{{name | shortDots}} <i ng-class="headerClass(name)" ng-click="sort(name)" tooltip="{{tooltip(name)}}" tooltip-append-to-body="1"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the click out to the sort icon and away from the entire header. There were enough icons up there that it was getting confusing.
Should be fixed. |
An extra history entry is being created when discover is initialized, if you click the discover navbar tab to refresh the app state the columns are reset properly to just _source, but now you can't use the back button. |
Pretty sure this is a problem in the grid, but if you use the back button to remove a column from the data table in the dashboard, the entire dashboard is rebuilt. |
LGTM |
Closes #3277
Advanced apologies for size. Most of the red comes from removing functionality from the discover controller (yay!) and moving it out to the doc_table.
Enhancements:
Changes:
$scope.fields
structure has been removed from discover and is now built as a reaction to the columns array changing. Thus it is not passed into the fieldChooser directive, rather $scope.columns is passed in.