Default columns configuration #3417
Conversation
|
It would appear that you did not sign the CLA with the same email as it associated with your github account. Can you go back and make sure they match? |
|
Actually, both email addresses are associated with my Github account. But you're right, I signed the CLA with my primary address and commited with the second one. I did not know that the check was automated. I have now signed the CLA a second time, with the same address I used in the commit. Let me know if that's enought. |
| 'defaultColumns': { | ||
| value: '["_source"]', | ||
| description: 'Columns displayed by default in the Discover tab', | ||
| type: 'json', |
There was a problem hiding this comment.
Why is this of type json? It should be a normal array like metaFields
rashidkpc
changed the title
|
I'm sorry, I messed up my rebase... I changed the type of defaultColumns to array like you asked. I'm afraid that the edition of this parameter won't work until PR #3259 is merged. |
| @@ -32,6 +32,10 @@ define(function (require) { | |||
| value: null, | |||
| description: 'The index to access if no index is set', | |||
| }, | |||
| 'defaultColumns': { | |||
| value: '["_source"]', | |||
There was a problem hiding this comment.
While it appears type: json has been removed, this value is still being specified as a string?
|
LGTM after merging master |
|
Lets hold on this for now pending this: https://github.com/elastic/kibana/pull/3526/files That pull moves all logic for determining what columns should be shown by default into the doc_table. The logic for when we show a remove button in the table header and field chooser will need some work if we are to support multiple columns whenever we drop down to 0. |
|
@vquemener you may want to have a look at #3526 and what it changed and see if you can find a nice way to map this up. |
|
hi @vquemener, Thanks! |
Closes #2964.
Add a variable to set default columns in the Discover tab.