Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _timestamp in doc tables + arrays in advanced settings #3259

Merged
merged 1 commit into from
Mar 25, 2015

Conversation

rashidkpc
Copy link
Contributor

While testing a pull I noticed _timestamp was not accessible in Discover. There were 2 reasons for this:

  • You could not add _timestamp to the metaFields array as array editing was broken. I broke out the logic for checking the type of a value for a setting and added tests for it.
  • The metaFields list was not being checked when merging the fields key of a hit.

Closes #3318

@panda01
Copy link
Contributor

panda01 commented Mar 6, 2015

I'm not entirely sure how to test this, I see metaFields in advanced settings, but don't know how it correlates to the discover screen.

Also, the settings that the user had there beforehand gets removed when this update is applied.

@rashidkpc
Copy link
Contributor Author

Which setting is removed? Changes to metaFields? Thats probably a plus since if they'd changed it the value would be invalid as it would've been set to a string.

Testing the array editing part is easy:

  1. on master, change metaFields, then pull the .kibana/config/4.0.2-snapshot document and look at the value. It will be a string. Remove the config doc
  2. On the pr branch, change metaFields, then pull the .kibana/config/4.0.2-snapshot document and look at the value. It will be a array.

Testing the _timestamp part of this will require enabling _timestamp. You'll notice on master there's no way to get it to show up without the "No cached mapping for this field" error in the doc viewer.

@lukasolson
Copy link
Member

LGTM!

lukasolson added a commit that referenced this pull request Mar 25, 2015
Fix _timestamp in doc tables + arrays in advanced settings
@lukasolson lukasolson merged commit 7e8c47a into elastic:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana4 no _source field after "fields reload"
3 participants