Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis event handler logic should move into the renderbot #3839

Closed
spalger opened this issue May 14, 2015 · 2 comments
Closed

Vis event handler logic should move into the renderbot #3839

spalger opened this issue May 14, 2015 · 2 comments
Labels

Comments

@spalger
Copy link
Contributor

spalger commented May 14, 2015

Currently event binding with visualizations is a bit of a mess. Click handlers for the filterbar are implemented in the visualize editor and the dashboard panel controllers, the tilemap's events are implemented in the vis type, and none of them are really conditional based on their need.

I think we should move them all into the Renderbot. The purpose of the renderbot is to tie together a kibana Vis object and a DOM node and seems like the perfect place to implement this.

This also seems like a good place to implement #2716

@spalger
Copy link
Contributor Author

spalger commented May 22, 2015

This needs to handle all event listeners, and remove listeners from state. They can't be serialized and shouldn't have been added to state to begin with.

@timroes
Copy link
Contributor

timroes commented Aug 13, 2018

Outdated.

@timroes timroes closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants