Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moment Timezone has no data for Browser #38515

Closed
liza-mae opened this issue Jun 9, 2019 · 4 comments · Fixed by #57850
Closed

Moment Timezone has no data for Browser #38515

liza-mae opened this issue Jun 9, 2019 · 4 comments · Fixed by #57850
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Operations Team label for Operations Team test_ui_functional test

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Jun 9, 2019

Kibana version: 7.2 cloud

Elasticsearch version: 7.2 cloud

OS: Ubuntu 16

Browser version: Firefox/Chrome Latest

Original install method (e.g. download page, yum, from source, etc.):
Cloud staging

Describe the bug:
I am seeing some timezone errors on the browser when loading sample data into dashboard.

Steps to reproduce:

  1. Install ES/KBN Cloud
  2. Load sample data into dashboard
  3. Observe errors:

Unknown time-zone ID: Browser and internal error pop-up

In Console:

Moment Timezone has no data for Browser. See http://momentjs.com/timezone/docs/#/data-loading/.

SearchError: "Internal Server Error"
_construct https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/bundles/commons.bundle.js:3
Wrapper https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/bundles/commons.bundle.js:3
SearchError https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/bundles/commons.bundle.js:3
searching https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/bundles/commons.bundle.js:5
processQueue https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
scheduleProcessQueue https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
$digest https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
$apply https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
done https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
completeRequest https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
requestLoaded https://65e9b0add30a49979501af0fffa0d27e.us-east-1.aws.staging.foundit.no:9243/built_assets/dlls/vendors.bundle.dll.js:516
Possibly unhandled rejection: {"name":"SearchError","status":500,"title":"InternalServerError","path":"/_msearch"}

Screenshot from 2019-06-09 13-58-27

@liza-mae liza-mae added the Team:Operations Team label for Operations Team label Jun 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@liza-mae
Copy link
Contributor Author

liza-mae commented Jun 9, 2019

Looks like this is caused after running the kibana functional test, so going to label it under test, since a new deployment did not show the problem.

@liza-mae liza-mae added failed-test A test failure on a tracked branch, potentially flaky-test test test_ui_functional labels Jun 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage

@jbudz
Copy link
Member

jbudz commented Aug 13, 2019

'Browser' is a text based setting that should roughly be translated to an empty moment constructor and not passed in. Probably passed through the select box.

jbudz added a commit to jbudz/kibana that referenced this issue Feb 18, 2020
Currently we set the global browser timezone based on the user's
advanced settings.  This setting includes a list of timezones and a
non-standard 'Browser' option which can be translated as set the
timezone to my current.  In order to avoid warnings and possible future
errors we only set timezone if it exists in moments list of installed
timezones

Closes elastic#38515
jbudz added a commit that referenced this issue Mar 20, 2020
* Only set timezone when user setting is a valid timezone

Currently we set the global browser timezone based on the user's
advanced settings.  This setting includes a list of timezones and a
non-standard 'Browser' option which can be translated as set the
timezone to my current.  In order to avoid warnings and possible future
errors we only set timezone if it exists in moments list of installed
timezones

Closes #38515

* feedback

* only set timezone if defined

* Update src/core/public/integrations/moment/moment_service.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.test.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.test.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* update test name

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jbudz added a commit that referenced this issue Mar 20, 2020
* Only set timezone when user setting is a valid timezone

Currently we set the global browser timezone based on the user's
advanced settings.  This setting includes a list of timezones and a
non-standard 'Browser' option which can be translated as set the
timezone to my current.  In order to avoid warnings and possible future
errors we only set timezone if it exists in moments list of installed
timezones

Closes #38515

* feedback

* only set timezone if defined

* Update src/core/public/integrations/moment/moment_service.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.test.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* Update src/core/public/integrations/moment/moment_service.test.ts

Co-Authored-By: Mikhail Shustov <restrry@gmail.com>

* update test name

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Operations Team label for Operations Team test_ui_functional test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants