Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox filters are being re-ordered. #44349

Closed
dave-wheeler opened this issue Aug 29, 2019 · 7 comments · Fixed by #50061
Closed

Firefox filters are being re-ordered. #44349

dave-wheeler opened this issue Aug 29, 2019 · 7 comments · Fixed by #50061
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.1 v7.4.0

Comments

@dave-wheeler
Copy link

Kibana version: 7.3.1
Elasticsearch version: 7.3.1
Server OS version: Archlinux
Browser version: Firefox 68.0.2 (This does not happen in Chrome)
Original install method (e.g. download page, yum, from source, etc.): Docker images

Description of the problem including expected versus actual behavior:
Expected behavior: Changing the state of a filter respects the order of all the filters.
Actual behavior: In visualizations and dashboards, when there are multiple filters, they are being grouped into pinned and unpinned filters, with the pinned group first. Any time any of the filters are enabled/disabled, pinned/unpinned, or included/excluded, the displayed order of the filters in both filter groups is being reversed. This also happens when the "all" versions of these actions are used. This makes it hard to quickly toggle filters on/off, because they are being moved around and require having to find in their new location each time they are toggled.

Steps to reproduce:

  1. Create a visualization with multiple filters.
  2. Enable/disable any of the filters, pin/unpin or include/exclude them. Or do the same things for all of them

Errors in browser console (if relevant): I'm not seeing anything relevant.
Provide logs and/or server output (if relevant): I'm not seeing anything relevant.

With pinned and unpinned filters:
Screenshot_2019-08-28_19-33-17

After enabling a pinned filter: All filters in each group are reversed
Screenshot_2019-08-28_19-33-56

After enabling a 2nd pinned filter. All of the filters in each group are reversed again.
Screenshot_2019-08-28_19-35-17

After excluding a filter. Everything reversed again.
Screenshot_2019-08-28_19-49-41

Pinning a filter. Groups members are reversed, then the newly pinned filter is prepended to the pinned group of filters.
Screenshot_2019-08-28_19-52-26

@kertal kertal self-assigned this Aug 29, 2019
@kertal
Copy link
Member

kertal commented Aug 29, 2019

Thank you for reaching out to us. I'll try to reproduce your problem

@kertal
Copy link
Member

kertal commented Aug 29, 2019

I've reproduced your issue, thx a lot for reporting this!

@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@kertal kertal added Feature:Filters bug Fixes for quality problems that affect the customer experience labels Aug 29, 2019
@kertal kertal removed their assignment Aug 29, 2019
@kertal
Copy link
Member

kertal commented Aug 29, 2019

It's related to #41567

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@dave-wheeler
Copy link
Author

We're now on 7.4.1. Is there any word/plan on fixing this?

@kertal
Copy link
Member

kertal commented Oct 28, 2019

dear @lizozom , could you have a look? many thx!

lizozom pushed a commit to lizozom/kibana that referenced this issue Nov 6, 2019
@lizozom lizozom mentioned this issue Nov 6, 2019
7 tasks
lizozom pushed a commit that referenced this issue Nov 10, 2019
* closes #44349, as well as SDH issue #64

* added tests to cover fix

* eslint

* Fixed test import
lizozom pushed a commit to lizozom/kibana that referenced this issue Nov 10, 2019
* closes elastic#44349, as well as SDH issue elastic#64

* added tests to cover fix

* eslint

* Fixed test import
lizozom pushed a commit that referenced this issue Nov 10, 2019
* closes #44349, as well as SDH issue #64

* added tests to cover fix

* eslint

* Fixed test import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.1 v7.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants