Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] SavedObject Mappings #50309

Closed
rudolf opened this issue Nov 12, 2019 · 8 comments
Closed

[Platform] SavedObject Mappings #50309

rudolf opened this issue Nov 12, 2019 · 8 comments
Assignees
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0

Comments

@rudolf
Copy link
Contributor

rudolf commented Nov 12, 2019

Allow plugins to register a Saved Object type with the associated Elasticsearch mappings.

Blocked by #52071

@rudolf rudolf added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 labels Nov 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@jasonrhodes
Copy link
Member

Is there any rough estimate on when this work will be done? Our NP migration PR is blocked on this work right now, and we're trying to evaluate if we need to hack around it or if we can wait for this. Thanks so much!

@joshdover
Copy link
Contributor

This is expected to be done in the next few weeks. @pgayvallet is working on some of the pre-req work right now.

Though I'm curious, how is this delaying your migration? You should be able to move all parts of your plugin to the New Platform while keeping a legacy plugin around with just these registration bits.

@jasonrhodes
Copy link
Member

@joshdover thanks -- @Kerry350 can you say more about what's blocking us here? I guess what Josh describes is what I was referring to as "hacking around it" but I've got no idea how easy or difficult that is :)

@pgayvallet pgayvallet self-assigned this Jan 22, 2020
@Kerry350
Copy link
Contributor

@jasonrhodes @joshdover Yep - so we have a couple of places using saved objects, things like “saved views” on the metrics page etc. The “blocker” is more that we’re trying to migrate fully to the NP in this PR, and delete our legacy plugin and folder in its entirety. If we need to work around this by reinstating the legacy plugin for these registrations, then we can do that.

@pgayvallet
Copy link
Contributor

#55012 was the blocking prerequisite for registering SO features such as mappings from NP and should be merged before the end of the week.

After that, implementing this issue should be rather easy. I'm expecting to start it next week. I should be done in a couple of week max.

@jasonrhodes
Copy link
Member

@Kerry350 sounds like we should go with the legacy plugin work-around for now and revisit in a few weeks. Thanks, both!

@pgayvallet
Copy link
Contributor

FYI, #55012 has been merged and I'm starting working on this issue. In the meantime, the legacy plugin work-around should be the way to go until this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants