Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend action execution request to provide finer detail on errors #52103

Closed
pmuellr opened this issue Dec 3, 2019 · 1 comment · Fixed by #52146
Closed

extend action execution request to provide finer detail on errors #52103

pmuellr opened this issue Dec 3, 2019 · 1 comment · Fixed by #52146

Comments

@pmuellr
Copy link
Member

pmuellr commented Dec 3, 2019

see #49219 (comment) for context

The suggestion is to change the action execution response from:

{
      status: 'error',
      message: "error in action \"{action-id}\" sending email: {message-from-service}"
}

to:

{
      status: 'error',
      message: "error sending email"
      actionId: {action-id},
      actionName: {just a suggestion, could be useful to have},
      detail: {message-from-service}
}

Not sure if adding additional "denormalization" of action info (like actionName) is really needed, but probably nice to have if it's available.

Should also look at CRUD operations, make sure those messages also don't require additional tweaking like this (don't think they will).

Is there anything in alerting that would be similar? Could be ...

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@pmuellr pmuellr self-assigned this Dec 3, 2019
pmuellr added a commit to pmuellr/kibana that referenced this issue Dec 3, 2019
pmuellr added a commit to pmuellr/kibana that referenced this issue Dec 4, 2019
pmuellr added a commit to pmuellr/kibana that referenced this issue Dec 9, 2019
timductive pushed a commit to timductive/kibana that referenced this issue Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants