Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch url should be moved to fixture in server tests #5555

Closed
epixa opened this issue Dec 2, 2015 · 0 comments
Closed

Elasticsearch url should be moved to fixture in server tests #5555

epixa opened this issue Dec 2, 2015 · 0 comments
Labels
good first issue low hanging fruit

Comments

@epixa
Copy link
Contributor

epixa commented Dec 2, 2015

The elasticsearch hostname and port are currently hardcoded throughout our server tests, but it would be better if they all pulled the hostname and port from a single fixture. Bonus points if that value is configurable from a single location so the stubbed tests would be in sync with the actual configured elasticsearch url.

Edit: #5529 includes where all of the current hostnames and ports exist for server tests.
@epixa epixa added the good first issue low hanging fruit label Dec 2, 2015
@bevacqua bevacqua self-assigned this Mar 14, 2016
@bevacqua bevacqua mentioned this issue Mar 14, 2016
Merged
bevacqua added a commit that referenced this issue Mar 14, 2016
@bevacqua
Merge pull request #6526 from bevacqua/cleanup/elasticsearch-url-soft…
dc87fe1 
…coded

Consolidate elasticsearch URL in configuration file. Fixes #5555
@bevacqua bevacqua removed their assignment Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epixa @bevacqua