Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart stays hidden when clicking back after opening spy #5832

Closed
jbudz opened this issue Jan 6, 2016 · 6 comments
Closed

Chart stays hidden when clicking back after opening spy #5832

jbudz opened this issue Jan 6, 2016 · 6 comments
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent v4.4.0

Comments

@jbudz
Copy link
Member

jbudz commented Jan 6, 2016

In Safari:

  1. Go to Discover
  2. Open histogram spy
  3. Click back button
    image

Tested on 4.4 and master. No console errors.

@jbudz jbudz added the bug Fixes for quality problems that affect the customer experience label Jan 6, 2016
@epixa
Copy link
Contributor

epixa commented Jan 6, 2016

Is this an issue in 4.3.1?

@jbudz
Copy link
Member Author

jbudz commented Jan 6, 2016

No, opening the spy doesn't seem to be adding anything to the history in 4.3.1

@epixa
Copy link
Contributor

epixa commented Jan 6, 2016

Interesting. If I'm understanding this correctly, we introduced history tracking for opening/closing the histogram spy in 4.4, and even though the history is changing when you click the back button, the spy itself is not toggling. Is that correct?

@jbudz
Copy link
Member Author

jbudz commented Jan 6, 2016

In 4.4+ the spy is toggling(the arrow changes direction, show/hide) but the histogram isn't re-rendering.

@simianhacker simianhacker changed the title Discover chart stays hidden when clicking back after opening spy Safari: Discover chart stays hidden when clicking back after opening spy Jan 7, 2016
@panda01
Copy link
Contributor

panda01 commented Jan 7, 2016

Sometimes I can get this to happen without hitting the back button on the dashboard.

@panda01
Copy link
Contributor

panda01 commented Jan 7, 2016

I don't know how, but maybe it has to do with a bunch of visualizations
2016-01-07 16_16_41

@rashidkpc rashidkpc changed the title Safari: Discover chart stays hidden when clicking back after opening spy Safari: Chart stays hidden when clicking back after opening spy Jan 8, 2016
@epixa epixa changed the title Safari: Chart stays hidden when clicking back after opening spy Chart stays hidden when clicking back after opening spy Jan 8, 2016
@rashidkpc rashidkpc self-assigned this Jan 8, 2016
@rashidkpc rashidkpc assigned panda01 and unassigned rashidkpc Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent v4.4.0
Projects
None yet
Development

No branches or pull requests

4 participants