Fix spy panel full screen with back button #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $scope.$watchCollection('spy.mode', function () { | ||
| $scope.fullScreenSpy = shouldHaveFullSpy(); | ||
| applyClassNames(); |
There was a problem hiding this comment.
Do we really need this one, and the one on :109?
There was a problem hiding this comment.
Oddly enough, yes.
|
LGTM then! |
| $scope.fullScreenSpy = $visEl.height() < minVisChartHeight; | ||
| } | ||
| return ($visEl.height() < minVisChartHeight) | ||
| && _.get($scope.spy, 'mode.fill') |
There was a problem hiding this comment.
Should these be has instead of get? As it stands now, if either mode.fill or mode.name are not truthy (e.g. 0), this will fail. That may be the intended behavior, but I wanted to make sure.
There was a problem hiding this comment.
_.get is correct, we need to know if both are truthy
|
LGTM other than that one comment. |
rashidkpc
added a commit
that referenced
this pull request
Jan 11, 2016
Fix spy panel full screen with back button
rashidkpc
pushed a commit
to rashidkpc/kibana
that referenced
this pull request
Jan 11, 2016
rashidkpc
pushed a commit
to rashidkpc/kibana
that referenced
this pull request
Jan 11, 2016
rashidkpc
pushed a commit
to rashidkpc/kibana
that referenced
this pull request
Jan 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5832