Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a11y dashboard panel tests #60766

Closed
bhavyarm opened this issue Mar 20, 2020 · 6 comments · Fixed by #77829 or #78181
Closed

Add a11y dashboard panel tests #60766

bhavyarm opened this issue Mar 20, 2020 · 6 comments · Fixed by #77829 or #78181

Comments

@bhavyarm
Copy link
Contributor

Dashboard panels have options and we need a11y tests for them:

Here are dashboard panel options in edit mode:
Screen Shot 2020-03-20 at 11 24 34 AM

Here are dashboard panel options in view mode:
Screen Shot 2020-03-20 at 11 24 50 AM

cc @LeeDr

@bhavyarm
Copy link
Contributor Author

Here is my dashboard test:
/test/accessibility/apps/dashboard.ts
You can add it either to the same test file or as another test under

/kibana/test/accessibility/apps

The test can skip inspect mode as that is already been tested.

@rashmivkulkarni
Copy link
Contributor

tests added : #62055

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 1, 2020

Edit mode tests are missing cc @rashmivkulkarni

@rashmivkulkarni
Copy link
Contributor

Dashboard Edit Mode :

  • run a11y tests on Dashboard Edit mode in xpack
    Click on Edit pencil button on any sample data loaded, run a11y tests on edit mode main page -
    covering: a11y tests on edit visualization, clone panel, edit panel title, customize time range, inspect, create drilldown, full screen, replace panel, delete from dashboard.

Screen Shot 2020-09-02 at 9 50 28 AM

Clicking on each of these options- will open other pops to make edits- will cover such test cases in other subsequent PRs.

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 2, 2020

I got two questions for you:

  1. Can you please note down what are the differences between dashboard view mode and dashboard edit mode in the top menu. We will need tests for it.
  2. "Clicking on each of these options- will open other pops to make edits- will cover such test cases in other subsequent PRs." - does this mean you won't be navigating back to dashboard app after going through these options or are you planning to cancel every edit action? Thanks!

@rashmivkulkarni
Copy link
Contributor

  • edit visualization - save and return
    -edit panel - show panel title, toggle button, reset , save, cancel

  • Customize panel time range - cancel, add to panel by changing the time .

  • Inspect - bring out the panel and close

  • create drilldown - separate PR

  • Full screen- maximize and minimize

  • replace panel - add controls

  • delete panel

  • save the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants