Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility dashboard edit panel tests #77829

Merged
merged 17 commits into from
Sep 21, 2020
Merged

Accessibility dashboard edit panel tests #77829

merged 17 commits into from
Sep 21, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Sep 17, 2020 •
edited
Loading

Ref Meta issue: #51456
Fixes #60766

@rashmivkulkarni rashmivkulkarni added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 18, 2020
@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review September 19, 2020 00:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni changed the title [wip]Accessibility dashboard panel tests Accessibility dashboard edit panel tests Sep 21, 2020
@rashmivkulkarni rashmivkulkarni mentioned this pull request Sep 21, 2020
Open
77 tasks
myasonik
myasonik approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run through the pages but the code seems ok 👍

Don't forget to add all the appropriate labels and whatnot to the PR!

@rashmivkulkarni rashmivkulkarni added v8.0.0 Feature:Dashboard Dashboard related features labels Sep 21, 2020
bhavyarm
bhavyarm approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm bhavyarm added the Team:QA Team label for QA Team label Sep 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@rashmivkulkarni rashmivkulkarni merged commit e15b4c4 into elastic:master Sep 21, 2020
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Sep 21, 2020
@rashmivkulkarni @elasticmachine
Accessibility dashboard edit panel tests (elastic#77829)
19f8439 
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through th ea11ySnapshot

* wip dashboard panel tests

* wip- accessibility

* wip -accessibility

* wip accessibility

* accessibility tests for dashboard edit panel

* accessibility tests

* removed the unused variables

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rashmivkulkarni rashmivkulkarni mentioned this pull request Sep 21, 2020
Closed
spalger added a commit that referenced this pull request Sep 21, 2020
@spalger
Revert "Accessibility dashboard edit panel tests (#77829)"
8d7aae0 
This reverts commit e15b4c4.
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@bhavyarm bhavyarm bhavyarm approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Project:Accessibility reverted Team:QA Team label for QA Team Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a11y dashboard panel tests
6 participants
@rashmivkulkarni @elasticmachine @kibanamachine @myasonik @bhavyarm @spalger