Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Add tests for the limited concurrency routes #71744

Closed
jfsiii opened this issue Jul 14, 2020 · 2 comments
Closed

[Ingest Manager] Add tests for the limited concurrency routes #71744

jfsiii opened this issue Jul 14, 2020 · 2 comments
Assignees
@jfsiii
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Jul 14, 2020

From #71552 & #71552 (review)

would like to see test coverage added for limited_concurrency.ts. At the minimum validate that we can get 429 status codes, and also validate that the counter decreases accordingly.

Tests are started in b8288ae

See https://github.com/elastic/kibana/blob/master/x-pack/plugins/security/server/authorization/app_authorization.test.ts for examples
@jfsiii jfsiii added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jul 14, 2020
@jfsiii jfsiii self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

This was referenced Jul 14, 2020
Merged
Merged
jfsiii pushed a commit that referenced this issue Jul 22, 2020
@elasticmachine
[Ingest Manager] Add more Fleet concurrency tests #71744 (#72338)
1343643 
* Refactor to make more testable. Add more tests.

* Remove ts-ignores. Add comment re: testing limitation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this issue Jul 23, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-timers
b4e78e7 
* master: (35 commits)
  Migrated karma tests to jest (elastic#72649)
  Migrate status page app to core (elastic#72017)
  Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834)
  Fix Firefox TSVB flaky test with switch index patterns (elastic#72882)
  [ML] Fixing link to index management from file data visualizer (elastic#72863)
  test: 💍 add test for sub-expression variables (elastic#71644)
  fix bug (elastic#72809)
  [keystore] use get_keystore in server cli (elastic#72954)
  Show step number instead of incomplete step. (elastic#72866)
  Fix bug where user can't add an exception when "close alert" is checked (elastic#72919)
  [Monitoring] Fix issues displaying alerts (elastic#72891)
  [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338)
  [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490)
  disable renovate masterIssue
  [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710)
  [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926)
  [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763)
  [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759)
  fix unexpected arguments to unload command
  Limits the upload size of lists to 9 meg size (elastic#72898)
  ...
@jfsiii
Copy link
Contributor Author

jfsiii commented Jul 23, 2020

closed by #72338

@jfsiii jfsiii closed this as completed Jul 23, 2020
@jfsiii jfsiii mentioned this issue Jul 24, 2020
Merged
jfsiii pushed a commit to jfsiii/kibana that referenced this issue Jul 24, 2020
@elasticmachine
[Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elas…
5251931 
…tic#72338)

* Refactor to make more testable. Add more tests.

* Remove ts-ignores. Add comment re: testing limitation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfsiii pushed a commit that referenced this issue Jul 24, 2020
@elasticmachine
[Ingest Manager] Add more Fleet concurrency tests #71744 (#72338) (#7…
2ba5b78 
…3213)

* Refactor to make more testable. Add more tests.

* Remove ts-ignores. Add comment re: testing limitation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfsiii jfsiii

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfsiii @elasticmachine