Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom filters with queries other than 'match' break interactive filtering #7246

Closed
Bargs opened this issue May 19, 2016 · 1 comment
Closed

Custom filters with queries other than 'match' break interactive filtering #7246

Bargs opened this issue May 19, 2016 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@Bargs
Copy link
Contributor

Bargs commented May 19, 2016

When adding a filter Kibana loops through the existing filters to see if you're actually just modifying one instead of adding a new one. At the linked line in the code, you can see it checks for filter.query.match[fieldName]. If an existing custom filter doesn't have a match query, this line will throw a Cannot read property 'foo' of undefined error the next time you try to add a filter (see gif below). This dramatically reduces the usefulness of editable filters since match is pretty limited in what it can do.

editablefilter
@Bargs Bargs added bug Fixes for quality problems that affect the customer experience P2 labels May 19, 2016
@Bargs Bargs mentioned this issue Jun 10, 2016
Closed
@Bargs Bargs mentioned this issue Jul 28, 2016
Closed
@Bargs
Copy link
Contributor Author

Bargs commented Jul 28, 2016

Some additional details and thoughts here #7884

Bargs pushed a commit to Bargs/kibana that referenced this issue Aug 22, 2016
@Bargs
Enable non-match queries in custom filters
ace67c4 
filterManager.add assumes that if it finds a filter that has a query
prop, then it must also have a match clause contained in that query.

User created custom filters may use term queries, range queries and
the like. Once you've added any filters without a match clause like that,
you can no longer add new filters by clicking the "add filter" icon
next to a field in the results. Instead you'll get an error that says
"Cannot read property '<your-prop>' of undefined" when filterManager.add
iterates over your custom filter with no match key.

Fixes: elastic#7246
Related: elastic#8038
@Bargs Bargs mentioned this issue Aug 22, 2016
Closed
Bargs added a commit to Bargs/kibana that referenced this issue Aug 22, 2016
@Bargs
Enable non-match queries in custom filters
a067db0 
filterManager.add assumes that if it finds a filter that has a query
prop, then it must also have a match clause contained in that query.

User created custom filters may use term queries, range queries and
the like. Once you've added any filters without a match clause like
that,
you can no longer add new filters by clicking the "add filter" icon
next to a field in the results. Instead you'll get an error that says
"Cannot read property '<your-prop>' of undefined" when filterManager.add
iterates over your custom filter with no match key.

Fixes: elastic#7246
Related: elastic#8038
@Bargs Bargs mentioned this issue Aug 22, 2016
Closed
@Bargs Bargs mentioned this issue Oct 10, 2016
Merged
@Bargs Bargs mentioned this issue Dec 8, 2016
Closed
@pieterlange pieterlange mentioned this issue Mar 10, 2017
Closed
1Copenut pushed a commit that referenced this issue Oct 11, 2023
@cee-chen
Upgrade EUI to v89.0.0 (#168396)
7708814 
`v88.5.4`⏩`v89.0.0`

---

## [`89.0.0`](https://github.com/elastic/eui/tree/v89.0.0)

- Added new `pushAnimation` prop to push `EuiFlyout`s, which enables a
slide in animation ([#7239](elastic/eui#7239))
- Updated `EuiComboBox` to use `EuiInputPopover` under the hood
([#7246](elastic/eui#7246))
- Added `inputPopoverProps` to `EuiComboBox`, which allows customizing
the underlying popover
([#7246](elastic/eui#7246))
- Added a new beta `EuiTextBlockTruncate` component for multi-line
truncation ([#7250](elastic/eui#7250))
- Updated `EuiBasicTable` and `EuiInMemoryTable` to support multi-line
truncation. This can be set via `truncateText.lines` in the `columns`
prop. ([#7254](elastic/eui#7254))

**Bug fixes**

- Fixed `EuiFlexGroup` and `EuiFlexGrid`'s `m` gutter size
([#7251](elastic/eui#7251))
- Fixed focus trap rerender issues in `EuiFlyout` with memoization
([#7259](elastic/eui#7259))
- Fixed a visual bug with `EuiContextMenu`'s animation between panels
([#7268](elastic/eui#7268))

**Breaking changes**

- EUI's global body font-size now respects the `font.defaultUnits`
token. This means that the global font size will use the `rem` unit by
default, instead of `px`.
([#7182](elastic/eui#7182))
- Removed exported `accessibleClickKeys`, `comboBoxKeys`, and
`cascadingMenuKeys` services. Use the generic `keys` service instead
([#7256](elastic/eui#7256))
- Removed `EuiColorStops` due to low usage
([#7262](elastic/eui#7262))
- Removed `EuiSuggest`. We recommend using `EuiSelectable` or
`EuiComboBox` instead
([#7263](elastic/eui#7263))
- Removed `euiHeaderAffordForFixed` Sass mixin, and `$euiHeaderHeight`
and `$euiHeaderHeightCompensation` Sass variables. Use the CSS variable
`--var(euiFixedHeadersOffset, 0)` instead.
([#7264](elastic/eui#7264))

**Accessibility**

- When using `rem` or `em` font units, EUI now respects, instead of
ignoring, browser default font sizes set by end users.
([#7182](elastic/eui#7182))
dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
@cee-chen @dej611
Upgrade EUI to v89.0.0 (elastic#168396)
887f985 
`v88.5.4`⏩`v89.0.0`

---

## [`89.0.0`](https://github.com/elastic/eui/tree/v89.0.0)

- Added new `pushAnimation` prop to push `EuiFlyout`s, which enables a
slide in animation ([elastic#7239](elastic/eui#7239))
- Updated `EuiComboBox` to use `EuiInputPopover` under the hood
([elastic#7246](elastic/eui#7246))
- Added `inputPopoverProps` to `EuiComboBox`, which allows customizing
the underlying popover
([elastic#7246](elastic/eui#7246))
- Added a new beta `EuiTextBlockTruncate` component for multi-line
truncation ([elastic#7250](elastic/eui#7250))
- Updated `EuiBasicTable` and `EuiInMemoryTable` to support multi-line
truncation. This can be set via `truncateText.lines` in the `columns`
prop. ([elastic#7254](elastic/eui#7254))

**Bug fixes**

- Fixed `EuiFlexGroup` and `EuiFlexGrid`'s `m` gutter size
([elastic#7251](elastic/eui#7251))
- Fixed focus trap rerender issues in `EuiFlyout` with memoization
([elastic#7259](elastic/eui#7259))
- Fixed a visual bug with `EuiContextMenu`'s animation between panels
([elastic#7268](elastic/eui#7268))

**Breaking changes**

- EUI's global body font-size now respects the `font.defaultUnits`
token. This means that the global font size will use the `rem` unit by
default, instead of `px`.
([elastic#7182](elastic/eui#7182))
- Removed exported `accessibleClickKeys`, `comboBoxKeys`, and
`cascadingMenuKeys` services. Use the generic `keys` service instead
([elastic#7256](elastic/eui#7256))
- Removed `EuiColorStops` due to low usage
([elastic#7262](elastic/eui#7262))
- Removed `EuiSuggest`. We recommend using `EuiSelectable` or
`EuiComboBox` instead
([elastic#7263](elastic/eui#7263))
- Removed `euiHeaderAffordForFixed` Sass mixin, and `$euiHeaderHeight`
and `$euiHeaderHeightCompensation` Sass variables. Use the CSS variable
`--var(euiFixedHeadersOffset, 0)` instead.
([elastic#7264](elastic/eui#7264))

**Accessibility**

- When using `rem` or `em` font units, EUI now respects, instead of
ignoring, browser default font sizes set by end users.
([elastic#7182](elastic/eui#7182))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epixa @Bargs