Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input controls crashes if index pattern is not available #72664

Closed
flash1293 opened this issue Jul 21, 2020 · 1 comment · Fixed by #79431
Closed

Input controls crashes if index pattern is not available #72664

flash1293 opened this issue Jul 21, 2020 · 1 comment · Fixed by #79431
Assignees
@DianaDerevyankina
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@flash1293
Copy link
Contributor

Kibana version: 7.9 BC2

Describe the bug: If an input control component is referencing an index pattern which can't be loaded (because it got removed), a blank panel is shown.

Steps to reproduce:

  1. Create input control vis with one form
  2. Save and put it on a dashboard
  3. Remove index pattern
  4. Go back to dashboard
  5. Blank panel is shown

Expected behavior:
6. Some kind of error message should be shown (maybe the error embeddable like it's happening for vislib charts)

Any additional context:

I didn't do a binary search, but this definitely worked better in 6.8:
Screenshot 2020-07-21 at 17 09 05
@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience regression Feature:Input Control Input controls visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Oct 5, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available
abc33c3 
Closes elastic#72664
@DianaDerevyankina DianaDerevyankina mentioned this issue Oct 5, 2020
Merged
7 tasks
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
DianaDerevyankina added a commit that referenced this issue Oct 8, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available (#79431)
4dc6f3b 
* Input controls crashes if index pattern is not available

Closes #72664

* Replace index pattern null type with undefined

* Move index pattern checks into FilterManager init function

* Rename indexPatternService to indexPatternsService to match other variables names
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Oct 8, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available (elastic#79431)
720021b 
* Input controls crashes if index pattern is not available

Closes elastic#72664

* Replace index pattern null type with undefined

* Move index pattern checks into FilterManager init function

* Rename indexPatternService to indexPatternsService to match other variables names
DianaDerevyankina added a commit that referenced this issue Oct 8, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available (#79431) (#7…
2549191 
…9979)

* Input controls crashes if index pattern is not available

Closes #72664

* Replace index pattern null type with undefined

* Move index pattern checks into FilterManager init function

* Rename indexPatternService to indexPatternsService to match other variables names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Input controls crashes if index pattern is not available DianaDerevyankina/kibana
4 participants
@timroes @flash1293 @elasticmachine @DianaDerevyankina