Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UI cleanup step on toggle deprecation with api call #73142

Closed
LeeDr opened this issue Jul 23, 2020 · 4 comments
Closed

Replace UI cleanup step on toggle deprecation with api call #73142

LeeDr opened this issue Jul 23, 2020 · 4 comments
Labels
Feature:Functional Testing Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:QA Team label for QA Team test_xpack_functional

Comments

@LeeDr
Copy link
Contributor

LeeDr commented Jul 23, 2020

Describe the feature: The functional UI test x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
currently toggles the deprecation logging setting from it's initial default state of On, to Off for the test. And then toggles it back On to set it back into the default state.

It would be better if that last step was in the after method and if it used the API directly to Elasticsearch to set it On.

re: #70071

Describe a specific use case for the feature:
In general, it should be our common practice to clean up the test cluster using API calls. We do this in some cases like removing data with esArchiver, but we probably miss other cases like any cluster settings or security users and roles, or things in reporting index, etc.

/cc @rashmivkulkarni @cjcenizal @jloleysens

@LeeDr LeeDr added Team:QA Team label for QA Team test_xpack_functional Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Functional Testing labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

These tests are currently skipped (see #96714), but I think this issue is still relevant once UA is re-enabled for the 8.0 upgrade.

@alisonelizabeth
Copy link
Contributor

I'm going to close this issue. The functional tests are being re-enabled and refactored via #109909. The deprecation logging logic is now being tested via our client-integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Functional Testing Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:QA Team label for QA Team test_xpack_functional
Projects
None yet
Development

No branches or pull requests

4 participants