New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Upgrade Assistant test to reflect hiding the UI #96714

Merged

cuff-links merged 10 commits into elastic:master from cuff-links:Change_UA_Test_To_Reflect_Hidden_UI

May 6, 2021

Contributor

cuff-links commented Apr 10, 2021

Summary

Closes #86546

Context

#95440 (comment)

This PR changes the tests in UA to only look for the container message that shows that we hid the UI. We also skipped all of the other tests that will be unskipped once we hit the final minor release.


          Added test to verify the UI changes for hiding the app.

ff31ac6

cuff-links added v8.0.0 Team:Kibana Management release_note:skip Feature:Upgrade Assistant Feature:Functional Testing v7.13.0 auto-backport v7.12.1 labels

Contributor

elasticmachine commented Apr 10, 2021

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Contributor Author

cuff-links commented Apr 12, 2021

@elasticmachine merge upstream

kibanamachine and others added 4 commits

April 12, 2021 00:12


          Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI

4aea841


          Running tests on repeat.

7ac6949


          Merge branch 'Change_UA_Test_To_Reflect_Hidden_UI' of github.com:cuff…

69f68e0

…-links/kibana into Change_UA_Test_To_Reflect_Hidden_UI


          Tests passed. Removing only clause to allow full suite to run.

da81bf9

Contributor

rashmivkulkarni commented Apr 14, 2021

@elasticmachine merge upstream


          Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI

alisonelizabeth mentioned this pull request

Replace UI cleanup step on toggle deprecation with api call #73142

Closed

Contributor Author

cuff-links commented Apr 20, 2021

@elasticmachine merge upstream


          Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI

f17901c

spalger added the v7.14.0 label

John Dorlus added 3 commits

May 5, 2021 11:55


          Merge branch 'master' of github.com:elastic/kibana into Change_UA_Tes…

7ed7dda

…t_To_Reflect_Hidden_UI


          Merge branch 'Change_UA_Test_To_Reflect_Hidden_UI' of github.com:cuff…

7b536a4

…-links/kibana into Change_UA_Test_To_Reflect_Hidden_UI


          Skipping firefox.

7bdb075

Contributor

kibanamachine commented May 5, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cuff-links requested a review from alisonelizabeth

May 5, 2021 22:28

alisonelizabeth approved these changes

View reviewed changes

Contributor

alisonelizabeth left a comment

Thanks for fixing these tests @cuff-links! I left a couple comments, but nothing blocking. Tests passed locally.

x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts Show resolved Hide resolved

x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

-                // Failing: See https://github.com/elastic/kibana/issues/86546
-                describe.skip('Upgrade Checkup', function () {
-                  this.tags('includeFirefox');
+                // Updated for the hiding of the UA UI.

Contributor

alisonelizabeth May 6, 2021

[nit] I might modify this comment to provide more context as to why some of the tests are skipped. Something like:

// UA is currently disabled by default. Some tests are skipped, but should be re-enabled for the last minor of the next major release.

cuff-links merged commit a1954b4 into elastic:master

Contributor

kibanamachine commented May 6, 2021

💔 Backport failed

Status	Branch	Result
❌	7.12	Commit could not be cherrypicked due to conflicts
❌	7.13	Commit could not be cherrypicked due to conflicts
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96714

cuff-links mentioned this pull request

Investigating Functional Test Failures in Upgrade Assistant #95440

Closed

yctercero pushed a commit to yctercero/kibana that referenced this pull request


          Changed Upgrade Assistant test to reflect hiding the UI (elastic#96714)

c6c046d

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Contributor

cjcenizal commented May 11, 2021

@cuff-links Could you please address these backport messages?

Contributor

kibanamachine commented May 12, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96714 or prevent reminders by adding the backport:skip label.

1 similar comment

Contributor

kibanamachine commented May 13, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96714 or prevent reminders by adding the backport:skip label.

cuff-links mentioned this pull request

[7.x] Changed Upgrade Assistant test to reflect hiding the UI (#96714) #100099

Merged

cuff-links pushed a commit to cuff-links/kibana that referenced this pull request


          Changed Upgrade Assistant test to reflect hiding the UI (elastic#96714)

e3866cd

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

cuff-links mentioned this pull request

[7.13] Changed Upgrade Assistant test to reflect hiding the UI (#96714) #100100

Merged

cuff-links pushed a commit to cuff-links/kibana that referenced this pull request


          Changed Upgrade Assistant test to reflect hiding the UI (elastic#96714)

0c9ee38

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

cuff-links mentioned this pull request

[7.12] Changed Upgrade Assistant test to reflect hiding the UI (#96714) #100101

Merged

cuff-links pushed a commit to cuff-links/kibana that referenced this pull request


          Changed Upgrade Assistant test to reflect hiding the UI (elastic#96714)

b27ac1b

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

Contributor

kibanamachine commented May 14, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

13 similar comments

Contributor

kibanamachine commented May 17, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 18, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 19, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 20, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 21, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 24, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 25, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 26, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 27, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 28, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented May 31, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Jun 1, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Jun 2, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

cuff-links pushed a commit that referenced this pull request


          [7.13] Changed Upgrade Assistant test to reflect hiding the UI (#96714)…

0a99fce

… (#100100)

* Changed Upgrade Assistant test to reflect hiding the UI (#96714)

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

* Added security service to fix type error. 

Added security service to fix type error which was missing from PR backport.

* Changed order of tests running to fix issue.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Contributor

kibanamachine commented Jun 3, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

cuff-links pushed a commit that referenced this pull request


          [7.12] Changed Upgrade Assistant test to reflect hiding the UI (#96714)…

4d8d144

… (#100101)

* Changed Upgrade Assistant test to reflect hiding the UI (#96714)

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

* Changed order of tests running to fix issue.

* Added security service declaration that was missing.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Contributor

kibanamachine commented Jun 4, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine removed the backport missing label

cuff-links pushed a commit that referenced this pull request


          [7.x] Changed Upgrade Assistant test to reflect hiding the UI (#96714) (

d996978

#100099)

* Changed Upgrade Assistant test to reflect hiding the UI (#96714)

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

* Changed placement of test suite due to it being destructive and causing other suites to fail.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Feature:Functional Testing Feature:Upgrade Assistant release_note:skip Team:Kibana Management v7.12.1 v7.13.0 v7.14.0 v8.0.0