Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Upgrade Assistant test to reflect hiding the UI #96714

Merged
merged 10 commits into from
May 6, 2021
Merged

Changed Upgrade Assistant test to reflect hiding the UI #96714

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ff31ac6
Added test to verify the UI changes for hiding the app.
Apr 10, 2021
4aea841
Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI
kibanamachine Apr 12, 2021
7ac6949
Running tests on repeat.
Apr 12, 2021
69f68e0
Merge branch 'Change_UA_Test_To_Reflect_Hidden_UI' of github.com:cuff…
Apr 12, 2021
da81bf9
Tests passed. Removing only clause to allow full suite to run.
Apr 12, 2021
6091222
Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI
kibanamachine Apr 14, 2021
f17901c
Merge branch 'master' into Change_UA_Test_To_Reflect_Hidden_UI
kibanamachine Apr 20, 2021
7ed7dda
Merge branch 'master' of github.com:elastic/kibana into Change_UA_Tes…
May 5, 2021
7b536a4
Merge branch 'Change_UA_Test_To_Reflect_Hidden_UI' of github.com:cuff…
May 5, 2021
7bdb075
Skipping firefox.
May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ export default function upgradeAssistantFunctionalTests({
const security = getService('security');
const log = getService('log');
const retry = getService('retry');
const testSubjects = getService('testSubjects');

// Failing: See https://github.com/elastic/kibana/issues/86546
describe.skip('Upgrade Checkup', function () {
this.tags('includeFirefox');
// Updated for the hiding of the UA UI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] I might modify this comment to provide more context as to why some of the tests are skipped. Something like:

// UA is currently disabled by default. Some tests are skipped, but should be re-enabled for the last minor of the next major release.

describe('Upgrade Checkup', function () {
this.tags('skipFirefox');
cuff-links marked this conversation as resolved.
Show resolved Hide resolved

before(async () => {
await esArchiver.load('empty_kibana');
Expand All @@ -33,11 +34,18 @@ export default function upgradeAssistantFunctionalTests({
await security.testUser.restoreDefaults();
});

it('allows user to navigate to upgrade checkup', async () => {
it('Overview page', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await retry.waitFor('Upgrade Assistant overview page to be visible', async () => {
return testSubjects.exists('comingSoonPrompt');
});
});

it.skip('allows user to navigate to upgrade checkup', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
});

it('allows user to toggle deprecation logging', async () => {
it.skip('allows user to toggle deprecation logging', async () => {
log.debug('expect initial state to be ON');
expect(await PageObjects.upgradeAssistant.deprecationLoggingEnabledLabel()).to.be('On');
expect(await PageObjects.upgradeAssistant.isDeprecationLoggingEnabled()).to.be(true);
Expand All @@ -60,15 +68,15 @@ export default function upgradeAssistantFunctionalTests({
});
});

it('allows user to open cluster tab', async () => {
it.skip('allows user to open cluster tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('cluster');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
'You have no cluster issues.'
);
});

it('allows user to open indices tab', async () => {
it.skip('allows user to open indices tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('indices');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
Expand Down