Skip to content

Commit

Permalink
[7.12] Changed Upgrade Assistant test to reflect hiding the UI (#96714)…
Browse files Browse the repository at this point in the history
… (#100101)

* Changed Upgrade Assistant test to reflect hiding the UI (#96714)

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts

* Changed order of tests running to fix issue.

* Added security service declaration that was missing.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
John Dorlus and kibanamachine authored Jun 4, 2021
1 parent 410ec27 commit 4d8d144
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 9 deletions.
30 changes: 22 additions & 8 deletions x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,36 @@ export default function upgradeAssistantFunctionalTests({
const esArchiver = getService('esArchiver');
const PageObjects = getPageObjects(['upgradeAssistant', 'common']);
const log = getService('log');
const security = getService('security');
const retry = getService('retry');
const testSubjects = getService('testSubjects');

// Updated for the hiding of the UA UI.
describe('Upgrade Checkup', function () {
this.tags('skipFirefox');

before(async () => {
await esArchiver.load('empty_kibana');
await security.testUser.setRoles(['global_upgrade_assistant_role']);
});

// Failing: See https://github.com/elastic/kibana/issues/86546
describe.skip('Upgrade Checkup', function () {
this.tags('includeFirefox');
before(async () => await esArchiver.load('empty_kibana'));
after(async () => {
await PageObjects.upgradeAssistant.waitForTelemetryHidden();
await esArchiver.unload('empty_kibana');
});

it('allows user to navigate to upgrade checkup', async () => {
it('Overview page', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await retry.waitFor('Upgrade Assistant overview page to be visible', async () => {
return testSubjects.exists('comingSoonPrompt');
});
});

it.skip('allows user to navigate to upgrade checkup', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
});

it('allows user to toggle deprecation logging', async () => {
it.skip('allows user to toggle deprecation logging', async () => {
log.debug('expect initial state to be ON');
expect(await PageObjects.upgradeAssistant.deprecationLoggingEnabledLabel()).to.be('On');
expect(await PageObjects.upgradeAssistant.isDeprecationLoggingEnabled()).to.be(true);
Expand All @@ -53,15 +67,15 @@ export default function upgradeAssistantFunctionalTests({
});
});

it('allows user to open cluster tab', async () => {
it.skip('allows user to open cluster tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('cluster');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
'You have no cluster issues.'
);
});

it('allows user to open indices tab', async () => {
it.skip('allows user to open indices tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('indices');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export default async function ({ readConfigFile }) {
resolve(__dirname, './apps/maps'),
resolve(__dirname, './apps/status_page'),
resolve(__dirname, './apps/timelion'),
resolve(__dirname, './apps/upgrade_assistant'),
resolve(__dirname, './apps/visualize'),
resolve(__dirname, './apps/uptime'),
resolve(__dirname, './apps/saved_objects_management'),
Expand All @@ -59,6 +58,7 @@ export default async function ({ readConfigFile }) {
resolve(__dirname, './apps/transform'),
resolve(__dirname, './apps/reporting_management'),
resolve(__dirname, './apps/management'),
resolve(__dirname, './apps/upgrade_assistant'),

// This license_management file must be last because it is destructive.
resolve(__dirname, './apps/license_management'),
Expand Down

0 comments on commit 4d8d144

Please sign in to comment.