Skip to content

Commit

Permalink
Changed Upgrade Assistant test to reflect hiding the UI (#96714)
Browse files Browse the repository at this point in the history
* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
John Dorlus and kibanamachine authored May 6, 2021
1 parent 3389274 commit a1954b4
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ export default function upgradeAssistantFunctionalTests({
const security = getService('security');
const log = getService('log');
const retry = getService('retry');
const testSubjects = getService('testSubjects');

// Failing: See https://github.com/elastic/kibana/issues/86546
describe.skip('Upgrade Checkup', function () {
this.tags('includeFirefox');
// Updated for the hiding of the UA UI.
describe('Upgrade Checkup', function () {
this.tags('skipFirefox');

before(async () => {
await esArchiver.load('empty_kibana');
Expand All @@ -33,11 +34,18 @@ export default function upgradeAssistantFunctionalTests({
await security.testUser.restoreDefaults();
});

it('allows user to navigate to upgrade checkup', async () => {
it('Overview page', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await retry.waitFor('Upgrade Assistant overview page to be visible', async () => {
return testSubjects.exists('comingSoonPrompt');
});
});

it.skip('allows user to navigate to upgrade checkup', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
});

it('allows user to toggle deprecation logging', async () => {
it.skip('allows user to toggle deprecation logging', async () => {
log.debug('expect initial state to be ON');
expect(await PageObjects.upgradeAssistant.deprecationLoggingEnabledLabel()).to.be('On');
expect(await PageObjects.upgradeAssistant.isDeprecationLoggingEnabled()).to.be(true);
Expand All @@ -60,15 +68,15 @@ export default function upgradeAssistantFunctionalTests({
});
});

it('allows user to open cluster tab', async () => {
it.skip('allows user to open cluster tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('cluster');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
'You have no cluster issues.'
);
});

it('allows user to open indices tab', async () => {
it.skip('allows user to open indices tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('indices');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
Expand Down

0 comments on commit a1954b4

Please sign in to comment.