Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ignore_above in the Indices settings #7324

Closed
timroes opened this issue May 29, 2016 · 10 comments
Closed

Show ignore_above in the Indices settings #7324

timroes opened this issue May 29, 2016 · 10 comments
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@timroes
Copy link
Contributor

timroes commented May 29, 2016

In the indices settings there is only a checkmark if a field is indexed. That looks like: "This field is indexed, I can search for stuff in it."

I have seen several cases where people wondered why some of the searches on this field didn't find the documents they were looking for and the problem was, that ignore_above was set for this field, and the content of that specific document(s) they were looking for, was longer than the limit and not indexed (most often talking about stacktraces stored in ES).

It would be nice if the settings screen make this somehow more clear to the user, that some values (above a specific length) are not indexed in that field and won't be found by Elasticsearch when searching for something in that fields.

If you don't know that behaviour it is very hard to understand why e.g. I can search for a class name in my not so long stacktrace and it will find the stacktraces, but if I search for a classname that only appears in longer stacktraces it won't find the documents.

Distinction from #4801: That issue wants to warn when the user searches for something longer than ignore_above, I would like to show the user in the index settings, that some values might not be indexed and therefor not findable (even if she searches for something shorter than the ignore_above limit).

Small idea how it could look: showing a superscript info or warning icon with the number of ignore_above behind it and show a tooltip with information when the user hover over it.

@epixa
Copy link
Contributor

epixa commented Dec 12, 2016

This seems totally reasonable to me. Since the ignore_above value can be changed in the mappings at any time, we would need to make sure we craft the warning message to make it clear that the configuration was present at the time the mappings were cached.

@epixa epixa added :Management and removed discuss labels Dec 12, 2016
@w33ble w33ble added the good first issue low hanging fruit label Dec 29, 2016
@w33ble w33ble assigned w33ble and unassigned w33ble Jan 12, 2017
@jimgoodwin
Copy link

@w33ble did we decide this was more complex to do than as stated ?

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages and removed :Management DO NOT USE labels Nov 27, 2018
@timroes timroes removed the good first issue low hanging fruit label Mar 4, 2019
@djptek
Copy link

djptek commented Jun 28, 2021

Hi @timroes, saw this was a candidate for Kibana 7 then not implemented. @elastic/ecs were discussing how exposing this field in the UI might be useful in helping users make the right storage choice for their data in e.g. Security (unset ignore_above) vs Logging (set ignore_above) use cases.

Would this be an appropriate time to revisit?

@djptek
Copy link

djptek commented Jun 28, 2021

@jimczi ⬆️

@timroes timroes added Team:AppServices and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@timroes
Copy link
Contributor Author

timroes commented Jun 29, 2021

@djptek I am not sure if we would still want to persue the issue as it's outlined here. We're planning to move warning for not indexed too long field values into Discover (see discussion in #101232). So users will be able when viewing their data directly in Discover see if specific values got ignored. Do you feel there is an additional usage in showing that value still in the index pattern UI?

@djptek
Copy link

djptek commented Jun 29, 2021

Hi @timroes this has come up because formerly ECS has automatically added a value for this field under certain circumstances, to encourage best practice for the Logging use case, however, it turns out this is potentially a very bad thing for the Security use case so we're removing that see elastic/ecs#1483

So, more than showing the value of ignore_above the goal is to give the user visibility of this field and agency should they wish to set/unset the field according to their use case.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 22, 2021
@mattkime mattkime added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cjcenizal
Copy link
Contributor

@timroes Can you specify which UI you're referring to? Is it the Index Patterns UI, Index Management, or something else?

@timroes
Copy link
Contributor Author

timroes commented Sep 13, 2021

I was referring to the index patterns UI (the only thing that existed 2016 :D) Thus the previous appServices label was imho correct.

That said, as in my above comment mentioned, I am not sure if that's really anything we still want to do that. ignore_above can be changed in the mapping thus showing it in the index pattern UI might not be that good, since it's not necessarily reflecting the state of all indexed documents.

We're currently working on showing ignored values in Discover (since with the switch to the fields API this has become mandatory), see #101232 and elastic/elasticsearch#74121

At that point we'd show wawrnings on values in Discover directly if they weren't indexed, and thus are not searchable (since it theoretically can even apply to just one value within an array of values in one document). I think that is the more desired approach to go with, so from my side there is no need for this feature anymore. Please feel free to close this if you agree.

@timroes timroes closed this as completed Sep 13, 2021
@timroes timroes reopened this Sep 13, 2021
jbudz pushed a commit that referenced this issue Dec 18, 2023
`v90.0.0`⏩`v91.0.0-backport.0`

⚠️ While this upgrade pings many teams and has a large code diff, **the
majority of the changes are snapshots or tests-related** and do not
touch source code, so should theoretically only need a code review and
not dedicated QA.

The changes in EUI that required a large swathe of these updates are:

- **EuiPopover** removed an extra unnecessary `<div>` wrapper on its
anchors, which affected many snapshots and a few CSS overrides, which
should have been updated
- **EuiButtonGroup** now renders `<button>` elements instead of `<input
type="radio">` elements for single selection, which affected both
snapshots and E2E tests
- **EuiSuperDatePicker**'s absolute date input now requires an `Enter`
keypress when parsing dates (affected E2E tests)
- **EuiComboBox**, when rendered with `singleSelection={{ plainText:
'true' }}`, no longer renders a pill (i.e. text). This combobox type now
behaves more like an `EuiFieldText`, where the selection is rendered via
input `value` instead. This affected a high amount of E2E tests (both
FTR and Cypress), both in terms of updating assertions and changing
selections, but should **not** significantly affect user experience -
see elastic/eui#7332 for more.

---

##
[`v91.0.0-backport.0`](https://github.com/elastic/eui/tree/v91.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

- Added `esqlVis`, `pipeBreaks`, and `pipeNoBreaks` icon glyphs.
- `EuiSelectable` now allows configurable text truncation via
`listProps.truncationProps`
([#7388](elastic/eui#7388))
- `EuiTextTruncate` now supports a new `calculationDelayMs` prop for
working around font loading or layout shifting scenarios
([#7388](elastic/eui#7388))

**Bug fixes**

- Fixed a bug with `EuiSelectable`s with custom `truncationProps`, where
scrollbar widths were not being accounted for
([#7392](elastic/eui#7392))

## [`91.0.0`](https://github.com/elastic/eui/tree/v91.0.0)

- Updated the background color of `EuiPopover`s in dark mode to increase
visibility & contrast against other page/panel backgrounds
([#7310](elastic/eui#7310))
- Memoized `EuiDataGrid` to prevent unneeded re-renders
([#7324](elastic/eui#7324))
- Added a configurable `role` prop to `EuiAccordion`
([#7326](elastic/eui#7326))
- Added a configurable `role` prop to `EuiGlobalToastList`
([#7328](elastic/eui#7328))
- For greater flexibility, `EuiSuperDatePicker` now allows users to
paste ISO 8601, RFC 2822, and Unix timestamps in the `Absolute` tab
input, in addition to timestamps in the `dateFormat` prop
([#7331](elastic/eui#7331))
- Plain text `EuiComboBox`es now behave more like a normal text
field/input. Backspacing will no longer delete the entire value, and
selected values can now be double clicked and copied.
([#7332](elastic/eui#7332))
- `EuiDataGrid`'s display settings popover now allows users to clear the
"Lines per row" input before typing in a new number
([#7338](elastic/eui#7338))
- Improved the UX of `EuiSuperDatePicker`'s Absolute tab for users
manually typing in timestamps
([#7341](elastic/eui#7341))
- Updated `EuiI18n`s with multiple `tokens` to accept dynamic `values`
([#7341](elastic/eui#7341))

**Bug fixes**

- Fixed `EuiComboBox`'s `onSearchChange` callback to pass the correct
`hasMatchingOptions` value
([#7334](elastic/eui#7334))
- Fixed an `EuiSelectableTemplateSitewide` bug where the `popoverButton`
behavior would break if passed a non-DOM React wrapper
([#7339](elastic/eui#7339))

**Deprecations**

- `EuiPopover`: deprecated `anchorClassName`. Use `className` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: deprecated `buttonRef`. Use `popoverRef` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: removed extra `.euiPopover__anchor` div wrapper. Target
`.euiPopover` instead if necessary
([#7311](elastic/eui#7311))
- Deprecated `EuiButtonGroup`'s `name` prop. This can safely be removed.
([#7325](elastic/eui#7325))

**Breaking changes**

- Removed deprecated `euiPaletteComplimentary` - use
`euiPaletteComplementary` Instead
([#7333](elastic/eui#7333))

**Accessibility**

- Updated `type="single"` `EuiButtonGroup`s to render standard buttons
instead of radio buttons under the hood, per recent a11y recommendations
([#7325](elastic/eui#7325))
- `EuiAccordion` now defaults to a less screenreader-noisy `group` role
instead of `region`. If your accordion contains significant enough
content to be a document landmark role, you may re-configure it back to
`region`. ([#7326](elastic/eui#7326))
- Reduced screen reader noisiness when sorting `EuiDataGrid` columns via
toolbar ([#7327](elastic/eui#7327))
- `EuiGlobalToastList` now defaults to a `log` role. If your toasts will
always require immediate user action, consider (with caution) using the
`alert` role instead.
([#7328](elastic/eui#7328))

**CSS-in-JS conversions**

- Updated `$euiFontFamily` and `$euiCodeFontFamily` to match Emotion
fonts ([#7332](elastic/eui#7332))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

8 participants