Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Remove proxyElasticMapsServiceInMaps yml setting #82132

Closed
thomasneirynck opened this issue Oct 30, 2020 · 6 comments · Fixed by #116184
Closed

[Breaking change] Remove proxyElasticMapsServiceInMaps yml setting #82132

thomasneirynck opened this issue Oct 30, 2020 · 6 comments · Fixed by #116184
Labels

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 30, 2020

Change description

Which release will ship the breaking change?

8.0

Describe the change. How will it manifest to users?

Remove the map.proxyElasticMapsServiceInMaps option. See #55611

Deployments who were previously using this flag to proxy request to EMS through Kibana (rather than having the user's browser call EMS directly), will no longer work. The map will not display in the Maps-app, SIEM, Uptime, Dashboards or Canvas.

How many users will be affected?

Not known. Kibana does not collect telemetry on this setting. Anecdotally (Discuss, sdh, ...), this seems a rarely used setting.

What can users do to address the change manually?

Use the on-prem version of the Elastic Maps Service, which is a Docker service that resides in the Elastic Docker registry, and install it in an accessible location in their internal network . Then, they will need to update the kibana.yml to point to this service. It should be released later in the 7.x cycle.

How could we make migration easier with the Upgrade Assistant?

Upgrade Assistant could check if map.proxyElasticMapsServiceInMaps is set, and if so, notify the user that it is deprecated and link to the migration docs.

Are there any edge cases?

Test Data

Will add link here to on-prem EMS, once it has been released.

Cross links

NA

@thomasneirynck thomasneirynck added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant Breaking Change NeededFor:Geo labels Oct 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@thomasneirynck thomasneirynck removed Breaking Change Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Oct 30, 2020
@cjcenizal
Copy link
Contributor

@thomasneirynck Would it be helpful if the Upgrade Assistant notified users that they were using this deprecated setting and linked them to migration docs?

@thomasneirynck
Copy link
Contributor Author

@cjcenizal actually, that would be a good idea. +1

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Nov 16, 2020

FYI I've updated the How could we make migration easier with the Upgrade Assistant? section in the issue description with CJ's suggestion.

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Apr 19, 2021

Hi @thomasneirynck! I'm going to add the Team:Geo label to this issue. The Upgrade Assistant will no longer be responsible for adding individual deprecation logic. Please consider using the deprecations service (#94845) provided by core to register this deprecation instead. All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions!

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants