Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Filter bar tags need focus state #82457

Closed
myasonik opened this issue Nov 3, 2020 · 2 comments · Fixed by #93411
Closed

(Accessibility) Filter bar tags need focus state #82457

myasonik opened this issue Nov 3, 2020 · 2 comments · Fixed by #93411
Assignees
@dokmic
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week WCAG A

Comments

@myasonik
Copy link
Contributor

myasonik commented Nov 3, 2020

Delete button on tags has no focus state.

The aria-label could also be improved to instead of simply reading delete if it would also say what it was deleting, as in aria-label=Delete ${tag.name}`.

Can either copy the styles from EUI (badges with onclick events) or we should probably actually just use EUI...
@myasonik myasonik added bug Fixes for quality problems that affect the customer experience Feature:Filters Project:Accessibility WCAG A loe:small Small Level of Effort Team:AppArch labels Nov 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. triaged labels Feb 24, 2021
@Dosant Dosant added the SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week label Mar 1, 2021
dokmic added a commit to dokmic/kibana that referenced this issue Mar 3, 2021
@dokmic
Fix accessibility of the filter bar tags (elastic#82457)
7f3f6f3
@dokmic dokmic mentioned this issue Mar 3, 2021
Merged
3 tasks
dokmic added a commit to dokmic/kibana that referenced this issue Mar 8, 2021
@dokmic
Fix accessibility of the filter bar tags (elastic#82457)
e8b47ec
dokmic added a commit that referenced this issue Mar 8, 2021
@dokmic
Fix accessibility in the global query bar (#93411)
8fa917c 
* Fix accessibility of the filter bar tags (#82457)
* Fix focus state keeping after removing a filter tag (#82503)
* Fix invalid state in the query bar date picker (#82513)
dokmic added a commit to dokmic/kibana that referenced this issue Mar 8, 2021
@dokmic
Fix accessibility in the global query bar (elastic#93411)
6232767 
* Fix accessibility of the filter bar tags (elastic#82457)
* Fix focus state keeping after removing a filter tag (elastic#82503)
* Fix invalid state in the query bar date picker (elastic#82513)
dokmic added a commit that referenced this issue Mar 8, 2021
@dokmic
Fix accessibility in the global query bar (#93411) (#93944)
b5ae4d5 
* Fix accessibility of the filter bar tags (#82457)
* Fix focus state keeping after removing a filter tag (#82503)
* Fix invalid state in the query bar date picker (#82513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dokmic dokmic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accessibility in the global query bar dokmic/kibana
4 participants
@myasonik @Dosant @dokmic @elasticmachine