Remove circular deps between KibanaApp team plugins #84750
Assignees
Labels
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
mshustov
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
added
the
Feature:Visualizations
|
|
|
It seems that kibana-app-services work on eliminating dependencies has also removed the |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Dec 22, 2020
alexwizp
added a commit
that referenced
this issue
Dec 22, 2020
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Dec 22, 2020
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Jan 11, 2021
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Jan 11, 2021
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Jan 12, 2021
…endencies (elastic#87797) * Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies Part of elastic#84750 * fix types
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Jan 12, 2021
alexwizp
added a commit
that referenced
this issue
Jan 13, 2021
* [Visualize] Remove circular deps between KibanaApp team plugins Part of #84750 * Update use_vis_byvalue.ts * Update use_saved_vis_instance.ts * add types * fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Jan 13, 2021
…tic#87994) * [Visualize] Remove circular deps between KibanaApp team plugins Part of elastic#84750 * Update use_vis_byvalue.ts * Update use_saved_vis_instance.ts * add types * fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this issue
Jan 13, 2021
…) (#88141) * [Visualize] Remove circular deps between KibanaApp team plugins Part of #84750 * Update use_vis_byvalue.ts * Update use_saved_vis_instance.ts * add types * fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Circular deps block plugin migration to TS project references #80508 and new build toolchain #69706
The main goal o adding TS project refs is to speed up TypeScript compilation time, time check time, and IDE responsiveness for the whole Kibana project. That's why it's considered as one of the top priorities for the upcoming 7.12 release.
Documentation
List of circular deps:
charts<-->expressions([Visualizations] Remove src/plugins/charts -> src/plugins/expressions cyclic dependencies #85788)charts<-->vis_default_editor([Visualizations] Remove charts - editor plugins cyclic dependencies #84887)vis_default_editor<-->visualizations(Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies #86988)vis_default_editor<-->visualize([Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies #85422)visualizations<-->visualize(Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies #87797)We also have a cyclic dependency between expressions and visualizations that can be solved by moving the
PersistedState from visualizations to expressions.The text was updated successfully, but these errors were encountered: