Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Move the Transaction type selector to the search bar #91131

Closed
4 tasks done
formgeist opened this issue Feb 11, 2021 · 1 comment · Fixed by #96685
Closed
4 tasks done

[APM] Move the Transaction type selector to the search bar #91131

formgeist opened this issue Feb 11, 2021 · 1 comment · Fixed by #96685
Assignees
@ogupte
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.13.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Feb 11, 2021 •
edited by ogupte
Loading

Summary

As we removed the UI filters, we have moved the Transaction type selector to its own place on the Transactions list view, but since we already have a transaction type prepend label on the Overview page, there's some inconsistency in how we display it. Furthermore, we want to allow the user to change the type on the Overview page.

Solution

Design examples

Screenshot 2021-02-11 at 14 46 04

Service overview selector

Screenshot 2021-02-11 at 14 46 15

Transactions list selector

Tasks

  • Move the selector to the search bar component as a its own select.
  • Replace the prepend label on the search bar on the Service overview with the type selector
  • Remove the Transactions title from the Transactions list page (correlations moves to the tab list [APM] Move "View correlations" button to the tabslist row #91080)
  • allow the user to change the type on the Overview page
@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result labels Feb 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist changed the title [APM] Reposition the Transaction type selector to the search bar [APM] Move the Transaction type selector to the search bar Feb 11, 2021
@ogupte ogupte self-assigned this Apr 7, 2021
ogupte added a commit to ogupte/kibana that referenced this issue Apr 9, 2021
@ogupte
[APM] Moves the Transaction type selector to the search bar (elastic#…
3d32085 
…91131)
@ogupte ogupte mentioned this issue Apr 9, 2021
Merged
ogupte added a commit that referenced this issue Apr 12, 2021
@ogupte @kibanamachine
[APM] Moves the transaction type selector to the search bar (#96685)
eb25c69 
* [APM] Moves the Transaction type selector to the search bar (#91131)

* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page

* removes unused i18n items

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit to ogupte/kibana that referenced this issue Apr 12, 2021
@ogupte @kibanamachine
[APM] Moves the transaction type selector to the search bar (elastic#…
2d9ba8d 
…96685)

* [APM] Moves the Transaction type selector to the search bar (elastic#91131)

* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page

* removes unused i18n items

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this issue Apr 12, 2021
@ogupte @kibanamachine
[APM] Moves the transaction type selector to the search bar (#96685) (#…
3129413 
…96850)

* [APM] Moves the Transaction type selector to the search bar (#91131)

* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page

* removes unused i18n items

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Moves the transaction type selector to the search bar ogupte/kibana
6 participants
@graphaelli @sorenlouv @ogupte @formgeist @elasticmachine @nehaduggal