Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-left testing on PRs #98339

Open
spalger opened this issue Apr 26, 2021 · 5 comments
Open

Shift-left testing on PRs #98339

spalger opened this issue Apr 26, 2021 · 5 comments
Assignees

Comments

@spalger
Copy link
Contributor

spalger commented Apr 26, 2021

Based on #98337

Once we're running the tests implemented as part of #98337 we should be able to analyze the transactions and spans created during these tests to understand how performance has been impacted by a set of changes. We'll need to start by looking at the data collected over several runs and try to understand what insights we can capture and report on in PRs with the goal of being able to report something like:

performance changes

❗️ Login page load
❗️ Dashboard - render 30 visualizations Gauge render time +2 sec (+300%)
⚠️ Discover - load large number of fields ES search time +1.5 sec (+50%)
Discover - load large number of fields Render doc table -0.4 sec (-20%)
Dashboard - render 30 visualizations Total render time +0.7 sec (+4%)

Link

@spalger spalger added the Team:Operations Team label for Operations Team label Apr 26, 2021
@spalger spalger self-assigned this Apr 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger removed their assignment Sep 28, 2021
@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@lizozom
Copy link
Contributor

lizozom commented Nov 2, 2021

We can already start analyzing the page-load transactions. Was talking to @suchcodemuchwow about this the other day.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 5, 2021
@lizozom
Copy link
Contributor

lizozom commented Nov 8, 2021

Partially addressed by #117861

@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@lizozom lizozom changed the title [performance testing] analyze APM data to test performance [performance testing] Extract performance metrics from telemetry May 12, 2022
@suchcodemuchwow
Copy link
Contributor

The title does not really correspond to what would wanna be achieved in this issue, just changing for now. I think we would like to create another issue for EBT.

@suchcodemuchwow suchcodemuchwow changed the title [performance testing] Extract performance metrics from telemetry Shift-left testing on PRs Jun 27, 2022
@lizozom
Copy link
Contributor

lizozom commented Jul 20, 2022

@suchcodemuchwow what are we trying to achieve with this issue? And is it's status correct?
Can you please update.

@jbudz jbudz added Team:Performance and removed Team:Operations Team label for Operations Team performance labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants