Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance test for login and home page #117861

Merged
merged 8 commits into from
Nov 18, 2021
Merged

Performance test for login and home page #117861

merged 8 commits into from
Nov 18, 2021

Conversation

suchcodemuchwow
Copy link
Contributor

  • Remove reporting-dashboard test from performance tests and add login page and home page tests to get
    performance metrics.
  • Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.

@suchcodemuchwow suchcodemuchwow added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Nov 8, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 8, 2021 •
edited
Loading

💚 CLA has been signed

@lizozom lizozom mentioned this pull request Nov 8, 2021
Open
@suchcodemuchwow suchcodemuchwow self-assigned this Nov 8, 2021
@suchcodemuchwow
Copy link
Contributor Author

@elasticmachine merge upstream

@suchcodemuchwow suchcodemuchwow marked this pull request as ready for review November 11, 2021 14:23
@suchcodemuchwow suchcodemuchwow requested a review from a team as a code owner November 11, 2021 14:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

LeeDr
LeeDr approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM - code and results review only

@suchcodemuchwow suchcodemuchwow requested a review from a team November 15, 2021 09:24
@suchcodemuchwow suchcodemuchwow requested a review from a team as a code owner November 15, 2021 09:24
@suchcodemuchwow suchcodemuchwow requested a review from a team November 15, 2021 09:24
@suchcodemuchwow suchcodemuchwow requested review from a team as code owners November 15, 2021 09:24
@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
refactor: refactor based on pr comments
29a0e15 
- Make network profiles more readable
- Use @ts-expect-error to detect a moment when selenium webdriver typings add setNetworkConditions declaration
- Check environment variable if it exist in NETWORK_PROFILES
@suchcodemuchwow
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #1 / APM API tests trial 8.0.0 correlations latency with data and opbeans-node args runs queries and returns results

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @suchcodemuchwow

@suchcodemuchwow suchcodemuchwow merged commit fcb855b into elastic:main Nov 18, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine kibanamachine mentioned this pull request Nov 18, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2021
@suchcodemuchwow @kibanamachine
Performance test for login and home page (elastic#117861)
c375c4b 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2021
@suchcodemuchwow @kibanamachine
Performance test for login and home page (elastic#117861)
ef8ee9e 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
@kibanamachine kibanamachine mentioned this pull request Nov 18, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 18, 2021
@kibanamachine @suchcodemuchwow
Performance test for login and home page (#117861) (#119089)
9764f01 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.

Co-authored-by: Baturalp Gurdin <9674241+suchcodemuchwow@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Nov 18, 2021
@kibanamachine @suchcodemuchwow
Performance test for login and home page (#117861) (#119088)
7e3e1f8 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.

Co-authored-by: Baturalp Gurdin <9674241+suchcodemuchwow@users.noreply.github.com>
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Nov 19, 2021
@suchcodemuchwow @ersin-erdal
Performance test for login and home page (elastic#117861)
b1b8642 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 19, 2021
@suchcodemuchwow @fkanout
Performance test for login and home page (elastic#117861)
b375c2a 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
@suchcodemuchwow @TinLe
Performance test for login and home page (elastic#117861)
3453807 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
@lizozom
Copy link
Contributor

lizozom commented Nov 21, 2021

@suchcodemuchwow does this resolve #103940 ?

If so, could you please close it?

dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@suchcodemuchwow @dmlemeshko
Performance test for login and home page (#117861)
b771070 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
@lizozom lizozom mentioned this pull request Nov 30, 2021
Merged
10 tasks
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@suchcodemuchwow @gbamparop
Performance test for login and home page (elastic#117861)
0e9197c 
- Remove reporting-dashboard test from performance tests and add login page and home page tests to get
performance metrics.
- Set network latency (KBN_TEST_NETWORK_LATENCY), download throughput (KBN_TEST_DOWNLOAD_THROUGHPUT) and upload throughput (KBN_TEST_UPLOAD_THROUGHPUT) through environment variables and fallback to default 100ms latency for network latency, 5MB for download throughput and 1MB for upload throughput.
@mshustov mshustov mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov left review comments

@LeeDr LeeDr LeeDr approved these changes

@tylersmalley tylersmalley Awaiting requested review from tylersmalley

@spalger spalger Awaiting requested review from spalger

Assignees

@suchcodemuchwow suchcodemuchwow

Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@suchcodemuchwow @elasticmachine @kibana-ci @kibanamachine @lizozom @tylersmalley @spalger @mshustov @LeeDr