Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Replace EuiCodeEditor 👉 Monaco editor #99445

Closed
alexwizp opened this issue May 6, 2021 · 1 comment · Fixed by #100684
Closed

[TSVB] Replace EuiCodeEditor 👉 Monaco editor #99445

alexwizp opened this issue May 6, 2021 · 1 comment · Fixed by #100684
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@alexwizp
Copy link
Contributor

alexwizp commented May 6, 2021 •
edited
Loading

Describe the feature:
TSVB still uses the EuiCodeEditor component in 2 places:

  1. src/plugins/vis_type_timeseries/public/application/components/markdown_editor.js
  2. src/plugins/vis_type_timeseries/public/application/components/panel_config/markdown.tsx

These code should be refactored to use Monaco editor instead.

This work must be done for the following reasons:

  1. EUI recommendation, see [EuiCodeEditor & EuiCodeBlock] Recommendations and migration guidance eui#3807
  2. Bundle optimization. I expect to see minus ~800Kb in async chunks
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp changed the title [TSVB] Replace EuiCodeEditor 👉 CodeEditor [TSVB] Replace EuiCodeEditor 👉 Monaco editor May 6, 2021
@Kuznietsov Kuznietsov mentioned this issue May 26, 2021
Merged
Kuznietsov added a commit to Kuznietsov/kibana that referenced this issue Jun 7, 2021
@Kuznietsov
Merge branch 'master' into elastic#99445
a42f32f
Kuznietsov added a commit to Kuznietsov/kibana that referenced this issue Jun 7, 2021
@Kuznietsov
Merge branch 'elastic#99445' of github.com:Kunzetsov/kibana into elas…
8ddf8fe 
…tic#99445
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 8, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
cdf60dd
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 8, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
1601e66
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 10, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
1b72e92
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 14, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
5437e26
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 16, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
5398a81
kibanamachine added a commit to Kuznietsov/kibana that referenced this issue Jun 18, 2021
@kibanamachine
Merge branch 'master' into elastic#99445
c2448cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Replaces EuiCodeEditor 👉 Monaco editor Kuznietsov/kibana
2 participants
@elasticmachine @alexwizp