Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timelion] Changes the version of removal message #100022

Merged
merged 8 commits into from
May 18, 2021
Merged

[Timelion] Changes the version of removal message #100022

merged 8 commits into from
May 18, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 13, 2021 •
edited
Loading

Summary

Part of https://github.com/elastic/kibana-team/issues/298

As we are going to remove the timelion app on 7.16 I changed the deprecation message on our callout and docs. I don't mention the exact minor but use the latest 7.x minor in case it changes.

Ui message:
image
Server message:
image

Docs preview: https://kibana_100022.docs-preview.app.elstc.co/guide/en/kibana/master/timelion.html

Checklist

Delete any items that are not applicable to this PR.

@stratoula stratoula changed the title Change the version of timelion removal on our documentation and warnings [Timelion] Changes the version of removal message May 13, 2021
@stratoula stratoula added Feature:TimelionApp v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 13, 2021
@stratoula stratoula marked this pull request as ready for review May 13, 2021 11:59
@stratoula stratoula requested a review from a team May 13, 2021 11:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested a review from KOTungseth May 13, 2021 11:59
@stratoula
Copy link
Contributor Author

stratoula commented May 13, 2021 •
edited
Loading

@KOTungseth are you ok with the text? The change is
will be removed in 8.0 to will be removed in the latest 7.x minor

cc @timductive @AlonaNadler

KOTungseth
KOTungseth approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the wording a little bit, but otherwise, LGTM!

docs/user/dashboard/timelion.asciidoc Outdated Show resolved Hide resolved
src/plugins/timelion/public/components/timelion_deprecation.tsx Outdated Show resolved Hide resolved
src/plugins/timelion/server/deprecations.ts Outdated Show resolved Hide resolved
src/plugins/timelion/server/deprecations.ts Outdated Show resolved Hide resolved
stratoula and others added 4 commits May 14, 2021 08:52
@stratoula @KOTungseth
Update docs/user/dashboard/timelion.asciidoc
35197ad 
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@stratoula @KOTungseth
Update src/plugins/timelion/public/components/timelion_deprecation.tsx
9b2b980 
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@stratoula @KOTungseth
Update src/plugins/timelion/server/deprecations.ts
141763c 
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@stratoula @KOTungseth
Update src/plugins/timelion/server/deprecations.ts
8cda451 
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexManagement 157 - -157

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
indexManagement 12 - -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelion 339.2KB 339.3KB +23.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
indexManagement 4 - -4
Unknown metric groups

API count

id before after diff
indexManagement 162 - -162

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 - -12
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -302

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

timductive
timductive approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@timductive timductive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy changes look good to me.

@stratoula stratoula merged commit 3926331 into elastic:master May 18, 2021
@stratoula stratoula mentioned this pull request May 18, 2021
Merged
stratoula added a commit to stratoula/kibana that referenced this pull request May 18, 2021
@stratoula @KOTungseth @kibanamachine
[Timelion] Changes the version of removal message (elastic#100022)
b805b9e 
* Change the version of timelion removal on our documentation and warnings

* Remove translations in order to be revisited

* Remove double

* Update docs/user/dashboard/timelion.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/public/components/timelion_deprecation.tsx

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request May 18, 2021
@stratoula @KOTungseth @kibanamachine
[Timelion] Changes the version of removal message (#100022) (#100266)
62601d2 
* Change the version of timelion removal on our documentation and warnings

* Remove translations in order to be revisited

* Remove double

* Update docs/user/dashboard/timelion.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/public/components/timelion_deprecation.tsx

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@stratoula @KOTungseth
@kibanamachine @yctercero
[Timelion] Changes the version of removal message (elastic#100022)
972e8da 
* Change the version of timelion removal on our documentation and warnings

* Remove translations in order to be revisited

* Remove double

* Update docs/user/dashboard/timelion.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/public/components/timelion_deprecation.tsx

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update src/plugins/timelion/server/deprecations.ts

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timductive timductive timductive approved these changes

@KOTungseth KOTungseth KOTungseth approved these changes

Assignees
No one assigned
Labels
Feature:TimelionApp release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @elasticmachine @kibanamachine @timductive @KOTungseth