Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions][Endpoint] Change search bar placeholder and make it dynamic by props #100049

Merged
merged 1 commit into from
May 14, 2021
Merged

[Security Solutions][Endpoint] Change search bar placeholder and make it dynamic by props #100049

merged 1 commit into from
May 14, 2021

Conversation

dasansol92
Copy link
Contributor

Summary

Just change searchBar placeholder by props. Add different placeholder text on trusted apps and event filters.
Screenshot 2021-05-13 at 18 01 08

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dasansol92 dasansol92 added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0 labels May 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.7MB 6.7MB +347.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 changed the title Change search bar placeholder and make it dynamic by props [Security Solutions][Endpoint] Change search bar placeholder and make it dynamic by props May 14, 2021
@dasansol92 dasansol92 marked this pull request as ready for review May 14, 2021 13:12
@dasansol92 dasansol92 requested a review from a team as a code owner May 14, 2021 13:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

paul-tavares
paul-tavares approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dasansol92 dasansol92 merged commit b6635b0 into elastic:master May 14, 2021
@dasansol92 dasansol92 mentioned this pull request May 14, 2021
Merged
dasansol92 added a commit to dasansol92/kibana that referenced this pull request May 14, 2021
@dasansol92
Change search bar placeholder and make it dynamic by props (elastic#1…
1b1aace 
…00049)
dasansol92 added a commit that referenced this pull request May 14, 2021
@dasansol92
Change search bar placeholder and make it dynamic by props (#100049) (#…
172f8ff 
…100125)
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 17, 2021
@dasansol92 @yctercero
Change search bar placeholder and make it dynamic by props (elastic#1…
10091f9 
…00049)
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@dasansol92 @yctercero
Change search bar placeholder and make it dynamic by props (elastic#1…
e8e0e64 
…00049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dasansol92 @kibanamachine @elasticmachine @kevinlog @paul-tavares